-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Stop using simplejson and use the standard library instead #19850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
7f06f9b to
f1a27a1
Compare
f1a27a1 to
b162b25
Compare
sarah-witt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Can we also update these, either in this PR or a separate one?
https://github.com/DataDog/integrations-core/blob/master/spark/datadog_checks/spark/spark.py#L8
https://github.com/DataDog/integrations-core/blob/master/vault/datadog_checks/vault/vault.py#L15-L18
I fixed them all, some other were missing, sorry about that |
cbd86c4 to
16eba46
Compare
What does this PR do?
Stop using simplejson and use the standard library instead
Motivation
Note: I'm not dropping the library (yet) because we need to switch to
jsonin the other repos (namely: extras, marketplace and internal). I'll do that in a follow-up PRReview checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged