Skip to content

Conversation

@ericfirth
Copy link
Contributor

@ericfirth ericfirth commented Mar 17, 2025

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

brett0000FF
brett0000FF previously approved these changes Mar 17, 2025
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as-is, but I left a suggestion for a slight revision that I think is a bit more clear. Thanks!

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed brett0000FF’s stale review March 24, 2025 17:26

Review from brett0000FF is dismissed.
Related teams and files:

  • documentation
    • amazon_msk/README.md
    • confluent_platform/README.md
    • kafka/README.md
    • rabbitmq/README.md
@ericfirth ericfirth force-pushed the eric.firth/add-dsm-to-integration-text branch from 1fbd6e4 to 0462d84 Compare March 24, 2025 17:26
@ericfirth
Copy link
Contributor Author

Approving as-is, but I left a suggestion for a slight revision that I think is a bit more clear. Thanks!

made the changes, but need re-approval to merge @brett0000FF

brett0000FF
brett0000FF previously approved these changes Mar 24, 2025
ericfirth and others added 2 commits March 24, 2025 16:05
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@ericfirth ericfirth force-pushed the eric.firth/add-dsm-to-integration-text branch from 0462d84 to 448a360 Compare March 24, 2025 20:05
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed brett0000FF’s stale review March 24, 2025 20:05

Review from brett0000FF is dismissed.
Related teams and files:

  • documentation
    • amazon_msk/README.md
    • confluent_platform/README.md
    • kafka/README.md
    • rabbitmq/README.md
@brett0000FF brett0000FF enabled auto-merge March 24, 2025 20:11
@brett0000FF brett0000FF added this pull request to the merge queue Mar 24, 2025
auto-merge was automatically disabled March 24, 2025 20:35

Pull Request is not mergeable

Merged via the queue into master with commit 4d6f0b5 Mar 24, 2025
34 checks passed
@brett0000FF brett0000FF deleted the eric.firth/add-dsm-to-integration-text branch March 24, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants