Skip to content

Conversation

@jamesreprise
Copy link
Contributor

What does this PR do?

Add FoundationDB metrics for:

  • Backup
  • Disaster Recovery
  • Process:
    • RSS of memory
    • Role count

Also adds a tag for the class type of the process.

Motivation

Desire for additional metrics covering backup, DR and etc.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

❌ Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.60%. Comparing base (9f203c5) to head (0430958).
⚠️ Report is 1192 commits behind head on master.

❌ Your project check has failed because the head coverage (73.51%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
foundationdb 73.51% <18.18%> (-8.95%) ⬇️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@dkirov-dd dkirov-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jamesreprise, thank you for your contribution!

Could you add the new metrics in the metadata.csv list as well as the tests?
Let me know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants