Make dependency resolution workflow names more explicit#19903
Merged
Make dependency resolution workflow names more explicit#19903
Conversation
alopezz
approved these changes
Mar 21, 2025
Contributor
alopezz
left a comment
There was a problem hiding this comment.
Fine with it but I'll let you consider a small suggestion
Co-authored-by: Alex Lopez <alex.lopez.zorzano@gmail.com>
Review from nubtron is dismissed.
Related teams and files:
- agent-integrations
- .github/workflows/resolve-build-deps.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
I strongly associate this workflow with the word "resolve", so it's hard for me to find it without that anchor.
There are also places where this is referred to as "dependency resolution", so I'm not a unicorn.
As for the "Publish artifacts" job, I forgot that it also opened a PR until I re-read it. Adding that to the job title as a breadcrumb for later.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged