Skip to content

Make dependency resolution workflow names more explicit#19903

Merged
iliakur merged 2 commits intomasterfrom
ik/renames
Mar 26, 2025
Merged

Make dependency resolution workflow names more explicit#19903
iliakur merged 2 commits intomasterfrom
ik/renames

Conversation

@iliakur
Copy link
Contributor

@iliakur iliakur commented Mar 21, 2025

What does this PR do?

Motivation

I strongly associate this workflow with the word "resolve", so it's hard for me to find it without that anchor.

There are also places where this is referred to as "dependency resolution", so I'm not a unicorn.

As for the "Publish artifacts" job, I forgot that it also opened a PR until I re-read it. Adding that to the job title as a breadcrumb for later.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

nubtron
nubtron previously approved these changes Mar 21, 2025
Copy link
Contributor

@nubtron nubtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

Copy link
Contributor

@alopezz alopezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with it but I'll let you consider a small suggestion

Co-authored-by: Alex Lopez <alex.lopez.zorzano@gmail.com>
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed nubtron’s stale review March 21, 2025 09:33

Review from nubtron is dismissed.
Related teams and files:

  • agent-integrations
    • .github/workflows/resolve-build-deps.yaml
@iliakur iliakur enabled auto-merge March 21, 2025 09:49
@iliakur iliakur disabled auto-merge March 26, 2025 09:40
@iliakur iliakur merged commit cdceb16 into master Mar 26, 2025
38 checks passed
@iliakur iliakur deleted the ik/renames branch March 26, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants