Skip to content

Allow timezone config option to be used in metric collection#19912

Merged
steveny91 merged 13 commits intomasterfrom
sy/ibmmq-timezone
Mar 26, 2025
Merged

Allow timezone config option to be used in metric collection#19912
steveny91 merged 13 commits intomasterfrom
sy/ibmmq-timezone

Conversation

@steveny91
Copy link
Contributor

@steveny91 steveny91 commented Mar 21, 2025

What does this PR do?

Old change that I had laying around that solved an escalation. https://datadoghq.atlassian.net/browse/AGENT-12517

The customer had a timezone set in their ibm mq instance that wasn't UTC, as a result a lot of their metrics were not getting collected as the check would think they were too old.

Not sure how to test it, but it was confirmed working here:
https://datadoghq.atlassian.net/browse/AGENT-12794

@steveny91 steveny91 requested a review from a team as a code owner March 21, 2025 16:41
@steveny91 steveny91 changed the title Sy/ibmmq timezone Respect timezone config option in metric collection Mar 21, 2025
@steveny91 steveny91 changed the title Respect timezone config option in metric collection Allow timezone config option to be used in metric collection Mar 21, 2025
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (0f77f71) to head (9ef652e).
Report is 21 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ibm_mq 91.46% <100.00%> (+40.03%) ⬆️
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🔥! one small nit- could you update the docs for the option here https://github.com/DataDog/integrations-core/blob/master/ibm_mq/datadog_checks/ibm_mq/data/conf.yaml.example#L189

Kyle-Neale
Kyle-Neale previously approved these changes Mar 24, 2025
@steveny91 steveny91 requested a review from a team as a code owner March 24, 2025 19:24
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed Kyle-Neale’s stale review March 24, 2025 19:24

Review from Kyle-Neale is dismissed.
Related teams and files:

  • agent-integrations
    • ibm_mq/assets/configuration/spec.yaml
    • ibm_mq/datadog_checks/ibm_mq/config.py
    • ibm_mq/datadog_checks/ibm_mq/config_models/defaults.py
    • ibm_mq/datadog_checks/ibm_mq/config_models/instance.py
    • ibm_mq/datadog_checks/ibm_mq/data/conf.yaml.example
    • ibm_mq/tests/test_ibm_mq_unit.py
@steveny91
Copy link
Contributor Author

@sarah-witt @Kyle-Neale I ended up separating the logic into a new config option. I thought about it some more, and since we haven't gotten many complaints about this type of issue and it's been a while since the queue_manager_timezone been out for a while, I didn't want to have a current users not be able to opt out of the new added behavior.

@steveny91 steveny91 enabled auto-merge March 26, 2025 19:41
@steveny91 steveny91 added this pull request to the merge queue Mar 26, 2025
Merged via the queue into master with commit fd23168 Mar 26, 2025
39 checks passed
@steveny91 steveny91 deleted the sy/ibmmq-timezone branch March 26, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants