Allow timezone config option to be used in metric collection#19912
Allow timezone config option to be used in metric collection#19912
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sarah-witt
left a comment
There was a problem hiding this comment.
Looks great 🔥! one small nit- could you update the docs for the option here https://github.com/DataDog/integrations-core/blob/master/ibm_mq/datadog_checks/ibm_mq/data/conf.yaml.example#L189
Review from Kyle-Neale is dismissed.
Related teams and files:
- agent-integrations
- ibm_mq/assets/configuration/spec.yaml
- ibm_mq/datadog_checks/ibm_mq/config.py
- ibm_mq/datadog_checks/ibm_mq/config_models/defaults.py
- ibm_mq/datadog_checks/ibm_mq/config_models/instance.py
- ibm_mq/datadog_checks/ibm_mq/data/conf.yaml.example
- ibm_mq/tests/test_ibm_mq_unit.py
|
@sarah-witt @Kyle-Neale I ended up separating the logic into a new config option. I thought about it some more, and since we haven't gotten many complaints about this type of issue and it's been a while since the |
What does this PR do?
Old change that I had laying around that solved an escalation. https://datadoghq.atlassian.net/browse/AGENT-12517
The customer had a timezone set in their ibm mq instance that wasn't UTC, as a result a lot of their metrics were not getting collected as the check would think they were too old.
Not sure how to test it, but it was confirmed working here:
https://datadoghq.atlassian.net/browse/AGENT-12794