Skip to content

Conversation

@bskinny
Copy link
Contributor

@bskinny bskinny commented May 14, 2025

What does this PR do?

This minimal manifest is needed for the first step in provisioning the crawler based Workato integration.

Motivation

To be integrated on behalf of Datadog.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@cit-pr-commenter
Copy link

PR Security Update

All commits in this PR up to and including e0b3cce have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack.

bskinny and others added 2 commits May 15, 2025 20:22
@urseberry Thanks for the edits!

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
@torosmassa torosmassa changed the title New Integration for Workato: Initial manifest as first step in provisioning [SAASINT-4161] New Integration for Workato: Initial manifest as first step in provisioning May 22, 2025
urseberry
urseberry previously approved these changes May 30, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed urseberry’s stale review June 11, 2025 18:55

Review from urseberry is dismissed. Related teams and files:

  • documentation
    • workato/README.md
@bskinny
Copy link
Contributor Author

bskinny commented Jun 11, 2025

@michellealbright12 @apiazza-dd Thanks, made the fixes. Also updated the Install instructions if you want to take a gander.

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
@bskinny
Copy link
Contributor Author

bskinny commented Jun 16, 2025

@apiazza-dd Thanks, down to just one failure. This is my first no-assets PR, let me know if I am not following the process.

Run ddev validate labeler
labeler
└── /home/runner/work/integrations-core/integrations-core/.github/workflows/conf
    ig/labeler.yml
    
    Check `workato` does not have an integration PR label

Errors: 1
Try running `ddev validate labeler --sync`
Error: Process completed with exit code 1.

@cmlaverdiere
Copy link
Contributor

@bskinny Yes you should install ddev (instructions here https://docs.datadoghq.com/developers/integrations/python/?tab=macos) and run that labeler command.

@bskinny
Copy link
Contributor Author

bskinny commented Jun 17, 2025

@cmlaverdiere I was able to run the ddev command locally but it made no noticeable change, no change to labeler.yml for instance.

[I] brianww@Brians-iMac-2 ~/b/d/integrations-core (external-pr/workato)> ddev validate labeler --sync
Adding config for `workato`
Successfully fixed /Users/brianww/github/integrations-core/.github/workflows/config/labeler.yml
labeler

Labeler configuration is valid

And I do not have permission to push a manual change to .github/workflows/config/labeler.yml to include workato.

Any idea what I should do?

@apiazza-dd
Copy link
Contributor

@bskinny Looks like all of the checks are passing - getting reapprovals from docs team and then will merge. Thanks for your patience and great job on your first asset PR!

@apiazza-dd apiazza-dd requested a review from urseberry June 19, 2025 12:59
@bskinny
Copy link
Contributor Author

bskinny commented Jun 20, 2025

Thanks @apiazza-dd !

@apiazza-dd apiazza-dd enabled auto-merge June 20, 2025 13:39
@apiazza-dd apiazza-dd added this pull request to the merge queue Jun 20, 2025
Merged via the queue into DataDog:master with commit 477e16b Jun 20, 2025
49 of 50 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 20, 2025
… step in provisioning (#20296)

* Initial, minimal, workato manifest as first step in provisioning

* Apply suggestions from code review

@urseberry Thanks for the edits!

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Workato integration: remove stub IMAGES_README

* Incorporate no-assets review feedback

* Fix formatting of setup instructions

* Update workato/README.md

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Apply suggestions from code review

Apply editorial updates

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Workato: No-assets update

* Workato: Induce build pipeline

* Workato: Remove trailing space

* Workato: update labeler.yml

* Workato: update CODEOWNERS

---------

Co-authored-by: Brian Williams <brian@mayalane.com>
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com> 477e16b
Kyle-Neale pushed a commit that referenced this pull request Jun 24, 2025
… step in provisioning (#20296)

* Initial, minimal, workato manifest as first step in provisioning

* Apply suggestions from code review

@urseberry Thanks for the edits!

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Workato integration: remove stub IMAGES_README

* Incorporate no-assets review feedback

* Fix formatting of setup instructions

* Update workato/README.md

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Apply suggestions from code review

Apply editorial updates

Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>

* Workato: No-assets update

* Workato: Induce build pipeline

* Workato: Remove trailing space

* Workato: update labeler.yml

* Workato: update CODEOWNERS

---------

Co-authored-by: Brian Williams <brian@mayalane.com>
Co-authored-by: Ursula Chen <58821586+urseberry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants