Skip to content

Conversation

@lucia-sb
Copy link
Contributor

What does this PR do?

Adds new features to the ddev size command:

  • Adds a new flag -send-metrics-dd-org in ddev size status to send metrics to Datadog.
  • Adds a new create-dashboard command to automatically create a dashboard in Datadog with those metrics.

Motivation

To provide an easier way to track and visualize size metrics.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

nubtron
nubtron previously approved these changes May 27, 2025
Copy link
Contributor

@nubtron nubtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note about the dashboard command help text, otherwise looks good! Approving in the meantime!

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed nubtron’s stale review May 27, 2025 08:54

Review from nubtron is dismissed. Related teams and files:

  • agent-integrations
    • ddev/src/ddev/cli/size/create_dashboard.py
@github-actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@lucia-sb lucia-sb marked this pull request as ready for review May 27, 2025 14:46
@lucia-sb lucia-sb requested a review from a team as a code owner May 27, 2025 14:46
@github-actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@lucia-sb lucia-sb added this pull request to the merge queue May 27, 2025
Merged via the queue into master with commit 6878f62 May 27, 2025
654 of 656 checks passed
@lucia-sb lucia-sb deleted the lucia/package_size_analyzer_improvements branch May 27, 2025 14:48
github-actions bot pushed a commit that referenced this pull request May 27, 2025
* basic status reporting

* integration into ddev

* clean commented code

* add diff mode

* add diff mode

* final diff version

* final diff version

* Added timeline mode and uncompressed sizes (#5025)

* Test ddev size status in GHA (by hijacking the slapr workflow)

* Timeline mode

* Try to fix job summaries

* Try fixing the job summaries again

* CI size status integration on master

* types added

* change --help

* fix

* fix typing

* fix typing

* fix types

* fix types

* fix typing

* fix typing

* fix typing

* fix typing

* fix tests for Windows

* Fix tests

* fix windows tests

* Fix tests

* Fix tests

* fix windows tests

* Final visualizations

* Changelog

* CI images integration and fixed typing

* user errors and dep and int versions

* user errors and dep and int versions

* user errors and dep and int versions

* fix timeline error

* Adding version, and json and markdown formats

* Fix test

* simplify code

* final fixes

* fix ddev windows

* fix lint

* testing ddev tests on windows

* initialize create_dashboard command

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* send metrics to dd

* create-dashboard command

* fixes

* test gha

* test gha

* test gha

* fixes

* fixes

* fixes

* fix

* getting commit timestamp

* getting commit timestamp

* Add commit timestamp

* correct comments

* correct comments

* Change comments

* Change number to constant

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Fix a comment

* Change number to constant

* Typing

* Change format flags

* change format input

* Correct test-common

* wip: Work in Progress

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Commiting to test send-metrics

* Fix typing

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Committing to test the send metrics

* Lints

* Fix tests

* Changelog

* Change create-dashboard help

* Simplify output formats

---------

Co-authored-by: Enrico Donnici <enrico.donnici@datadoghq.com> 6878f62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants