[postgres] Prevent incidents by detecting idle sessions holding locks#21182
Merged
sethsamuel merged 22 commits intomasterfrom Sep 17, 2025
Merged
[postgres] Prevent incidents by detecting idle sessions holding locks#21182sethsamuel merged 22 commits intomasterfrom
sethsamuel merged 22 commits intomasterfrom
Conversation
a423da6 to
b1d7066
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
0bd58a5 to
6bc6c1c
Compare
eric-weaver
reviewed
Sep 15, 2025
Co-authored-by: Eric Weaver <eweaver755@gmail.com>
sethsamuel
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding
postgresql.locks.idle_in_transaction_agemetric.Motivation
Locks can sit around quietly for a while — until someone else needs the same data. At that point, blocking kicks in, and while DBM will show you the blocking tree, it’s already too late: the incident has happened.
The idea behind this PR is to spot potentially problematic locks early and avoid those incidents. Imagine someone starts a transaction, updates some rows (which takes a lock), and then gets a call to head out for a beer. They forget to commit, and the lock just sits there. Nothing breaks… until a nightly batch job tries to touch the same data, and suddenly that forgotten lock causes a blocking cascade.
It doesn’t take a bar-goer to cause this, of course. A stuck or abandoned connection from the pool, or a software bug leaving a session idle with locks, can have the same effect. That’s why we’re adding a metric for idle sessions holding locks. The metric includes DB name, relation owner and name, user, app, and PID, so users can create monitors and act before the issue turns into an incident.
Trade-offs
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged