Skip to content

Conversation

@lucia-sb
Copy link
Contributor

@lucia-sb lucia-sb commented Sep 15, 2025

What does this PR do?

Adds a new helper method get_merge_base in the GitRepository class in ddev. It returns the commit hash of the common ancestor between HEAD and the given reference.

Motivation

The quality gates need to get the merge base in order to compare sizes in PRs.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link

⚠️ Recommendation: Add qa/skip-qa Label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.01%. Comparing base (d39952e) to head (bd0c626).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucia-sb lucia-sb marked this pull request as ready for review September 16, 2025 07:58
@lucia-sb lucia-sb requested a review from a team as a code owner September 16, 2025 07:58
Copy link
Contributor

@AAraKKe AAraKKe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lucia-sb lucia-sb added this pull request to the merge queue Sep 16, 2025
Merged via the queue into master with commit 96a8c4b Sep 16, 2025
322 of 327 checks passed
@lucia-sb lucia-sb deleted the lucia-sb/git-merge-base branch September 16, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants