Skip to content

Conversation

@AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented Dec 3, 2025

What does this PR do?

Fix subject in policy to allow pull requests to use it.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe requested a review from a team as a code owner December 3, 2025 14:36
@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Dec 3, 2025
@AAraKKe AAraKKe enabled auto-merge December 3, 2025 14:37
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

issuer: https://token.actions.githubusercontent.com

subject: repo:DataDog/integrations-core:ref:refs/heads/master
subject_pattern: repo:DataDog/integrations-core:(pull_request|ref:refs/head/master)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Subject pattern rejects master branch tokens

The new subject_pattern uses ref:refs/head/master (missing the s in heads), but GitHub OIDC sub claims for branch runs are repo:DataDog/integrations-core:ref:refs/heads/<branch>. Because the regex no longer matches the actual master subject, push or workflow_dispatch runs on master will fail to obtain STS credentials and the dispatcher workflow cannot manage runs except when invoked from pull_request. This regressively blocks the intended master events.

Useful? React with 👍 / 👎.

lucia-sb
lucia-sb previously approved these changes Dec 3, 2025
@AAraKKe AAraKKe added this pull request to the merge queue Dec 3, 2025
@AAraKKe AAraKKe removed this pull request from the merge queue due to a manual request Dec 3, 2025
@AAraKKe AAraKKe force-pushed the aarakke/fix-policy-3 branch from f9dc89f to e201517 Compare December 3, 2025 14:40
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed lucia-sb’s stale review December 3, 2025 14:40

Review from lucia-sb is dismissed. Related teams and files:

  • agent-integrations
    • .github/chainguard/self.test-dispatcher.sts.yaml
@AAraKKe
Copy link
Contributor Author

AAraKKe commented Dec 3, 2025

Just fixed a typo and since this is for testing I am merging now, lucia is busy with the release shadowing.

@AAraKKe AAraKKe merged commit 4df8df2 into master Dec 3, 2025
26 of 27 checks passed
@AAraKKe AAraKKe deleted the aarakke/fix-policy-3 branch December 3, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants