Skip to content

Conversation

@iliakur
Copy link
Contributor

@iliakur iliakur commented Dec 12, 2025

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.99%. Comparing base (5eda6a1) to head (e54869b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official
Copy link
Contributor

datadog-official bot commented Dec 12, 2025

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

test_common_metrics[False] from test_pg_integration.py (Datadog) (Fix with Cursor)
Some metrics are collected but not asserted:
Asserted Metrics:
	- dd.postgres.operation.time
	- postgresql.activity.wait_event
	- postgresql.archiver.archived_count
	- postgresql.archiver.failed_count
	- postgresql.before_xid_wraparound
	- postgresql.bgwriter.buffers_alloc
	- postgresql.bgwriter.buffers_backend
	- postgresql.bgwriter.buffers_backend_fsync
...
test_common_metrics[True] from test_pg_integration.py (Datadog) (Fix with Cursor)
Some metrics are collected but not asserted:
Asserted Metrics:
	- dd.postgres.operation.time
	- postgresql.activity.wait_event
	- postgresql.archiver.archived_count
	- postgresql.archiver.failed_count
	- postgresql.before_xid_wraparound
	- postgresql.bgwriter.buffers_alloc
	- postgresql.bgwriter.buffers_backend
	- postgresql.bgwriter.buffers_backend_fsync
...

🧪 2 Tests failed

test_custom_queries[incorrect formatting custom query] from test_integration.py (Datadog) (Fix with Cursor)
assert "Invalid syntax: no viable alternative at input 'selectt'." in "WARNING  urllib3.connectionpool:connectionpool.py:327 Connection pool is full, discarding connection: localhost. Connection pool size: 4\nWARNING  urllib3.connectionpool:connectionpool.py:327 Connection pool is full, discarding connection: localhost. Connection pool size: 4\nERROR    datadog_checks.base.checks.base.cloudera:api_v7.py:221 Skipping custom query query='selectt' tags=('baz',) due to the following exception: 'HTTPResponse' object has no attribute 'getheaders'\n"
 +  where "WARNING  urllib3.connectionpool:connectionpool.py:327 Connection pool is full, discarding connection: localhost. Connection pool size: 4\nWARNING  urllib3.connectionpool:connectionpool.py:327 Connection pool is full, discarding connection: localhost. Connection pool size: 4\nERROR    datadog_checks.base.checks.base.cloudera:api_v7.py:221 Skipping custom query query='selectt' tags=('baz',) due to the following exception: 'HTTPResponse' object has no attribute 'getheaders'\n" = <_pytest.logging.LogCaptureFixture object at 0x7f10bca210f0>.text
test_custom_queries[non existent metric custom query] from test_integration.py (Datadog) (Fix with Cursor)
assert "Invalid metric 'fake_foo' in 'select fake_foo'" in "ERROR    datadog_checks.base.checks.base.cloudera:api_v7.py:221 Skipping custom query query='select fake_foo' tags=('baz',) due to the following exception: 'HTTPResponse' object has no attribute 'getheaders'\n"
 +  where "ERROR    datadog_checks.base.checks.base.cloudera:api_v7.py:221 Skipping custom query query='select fake_foo' tags=('baz',) due to the following exception: 'HTTPResponse' object has no attribute 'getheaders'\n" = <_pytest.logging.LogCaptureFixture object at 0x7f10bca22b10>.text
This comment will be updated automatically if new data arrives.
* Fix with Cursor requires Datadog plugin ≥v2.17.0
🔗 Commit SHA: e54869b | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@AAraKKe AAraKKe added this pull request to the merge queue Dec 12, 2025
Merged via the queue into master with commit 264caef Dec 12, 2025
354 of 366 checks passed
@AAraKKe AAraKKe deleted the ik/release-dcd-again branch December 12, 2025 13:29
github-actions bot pushed a commit to ConnectionMaster/integrations-core that referenced this pull request Dec 12, 2025
* [Release] Bumped datadog_checks_dev version to 35.5.0

* [Release] Update metadata 264caef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants