DDS: Microsoft DNS Audit Logs: Add OCSF pipelines#22567
DDS: Microsoft DNS Audit Logs: Add OCSF pipelines#22567jaypatel7-crest wants to merge 15 commits intoDataDog:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b7b23000f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: Map `Event.System.Security.UserID` to `ocsf.actor.user.uid` | ||
| sources: | ||
| - Event.System.Security.UserID | ||
| sourceType: attribute | ||
| target: ocsf.actor.user.uid | ||
| targetFormat: integer | ||
| preserveSource: true |
There was a problem hiding this comment.
Windows Event.System.Security.UserID values are SIDs (e.g., S-1-5-21-... in the samples within this same file), so coercing them to integer will fail and typically results in a null/empty ocsf.actor.user.uid, losing user attribution for most events. Consider mapping this field with targetFormat: string (or leaving it unformatted) to keep the SID intact; the current integer conversion will drop valid values.
Useful? React with 👍 / 👎.
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
2 participants
What does this PR do?
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged