Skip to content

Fix Azure SQL Server major version parsing#22573

Open
jimmystridh wants to merge 2 commits intoDataDog:masterfrom
jimmystridh:feature/sqlserver-azure-major-version
Open

Fix Azure SQL Server major version parsing#22573
jimmystridh wants to merge 2 commits intoDataDog:masterfrom
jimmystridh:feature/sqlserver-azure-major-version

Conversation

@jimmystridh
Copy link

Summary

  • Fix parse_sqlserver_major_version to handle Azure SQL version strings (e.g. Microsoft SQL Azure (RTM) - 12.0.2000.8)
  • The previous regex only matched 4-segment versions (x.x.x.x), causing Azure SQL versions to return None
  • Add priority-ordered pattern matching to support both on-prem and Azure formats

Test plan

  • Added unit test for Azure SQL version string
  • Existing on-prem version tests still pass

🤖 Generated with Claude Code

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.36%. Comparing base (f2a5a33) to head (32a943c).
⚠️ Report is 230 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AAraKKe
AAraKKe previously approved these changes Feb 9, 2026
Copy link
Contributor

@AAraKKe AAraKKe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from the agent-integrations point of view. Will ping DBM to take a look at it themselves.

@sethsamuel
Copy link
Contributor

Thanks for the contribution! Could you please add some examples/unit tests for each of the new regexes?

@AAraKKe
Copy link
Contributor

AAraKKe commented Feb 9, 2026

Just noticed the validations were failing, for some reason this didn't fully load before. The Validations errors are expected until you merge from master the latest changes. There was an update for licenses there.

@jimmystridh jimmystridh force-pushed the feature/sqlserver-azure-major-version branch from fee5775 to 32a943c Compare February 10, 2026 08:59
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed AAraKKe’s stale review February 10, 2026 08:59

Review from AAraKKe is dismissed. Related teams and files:

  • agent-integrations
    • sqlserver/changelog.d/22573.fixed
    • sqlserver/datadog_checks/sqlserver/utils.py
    • sqlserver/tests/test_unit.py
@AAraKKe AAraKKe requested a review from sethsamuel February 16, 2026 10:12
@AAraKKe
Copy link
Contributor

AAraKKe commented Feb 16, 2026

Hi @sethsamuel just requested your review to merge, let me know if you think it is good to go.

Copy link
Contributor

@sethsamuel sethsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add examples and tests for each of the regex patterns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants