Fix Azure SQL Server major version parsing#22573
Fix Azure SQL Server major version parsing#22573jimmystridh wants to merge 2 commits intoDataDog:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
AAraKKe
left a comment
There was a problem hiding this comment.
Good from the agent-integrations point of view. Will ping DBM to take a look at it themselves.
|
Thanks for the contribution! Could you please add some examples/unit tests for each of the new regexes? |
|
Just noticed the validations were failing, for some reason this didn't fully load before. The Validations errors are expected until you merge from master the latest changes. There was an update for licenses there. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fee5775 to
32a943c
Compare
Review from AAraKKe is dismissed. Related teams and files:
- agent-integrations
- sqlserver/changelog.d/22573.fixed
- sqlserver/datadog_checks/sqlserver/utils.py
- sqlserver/tests/test_unit.py
|
Hi @sethsamuel just requested your review to merge, let me know if you think it is good to go. |
sethsamuel
left a comment
There was a problem hiding this comment.
Please add examples and tests for each of the regex patterns
Summary
parse_sqlserver_major_versionto handle Azure SQL version strings (e.g.Microsoft SQL Azure (RTM) - 12.0.2000.8)x.x.x.x), causing Azure SQL versions to returnNoneTest plan
🤖 Generated with Claude Code