fix: build PostgreSQL with GSSAPI#22905
Merged
eric-weaver merged 1 commit intoDataDog:masterfrom Mar 19, 2026
Merged
Conversation
Contributor
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 445c4aaa3a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This PR add --with-gssapi to the PostgreSQL configure step. krb5 1.20.1 is already built in the builder images, so this is a one-line change per platform. Fixes DataDog#22742
aiuto
approved these changes
Mar 16, 2026
eric-weaver
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add --with-gssapi to the PostgreSQL configure step. krb5 1.20.1 is already built in the builder images, so this is a one-line change per platform.
Fixes #22742
Motivation
The previous agent used psycopg2-binary, which bundled its own libpq with GSSAPI and Kerberos libraries (libgssapi_krb5, libkrb5, libsasl2, etc.). The psycopg3 migration (PR #21173, v22.18.0) lost this.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged