Skip to content

fix: build PostgreSQL with GSSAPI#22905

Merged
eric-weaver merged 1 commit intoDataDog:masterfrom
hvtuananh:gssapi
Mar 19, 2026
Merged

fix: build PostgreSQL with GSSAPI#22905
eric-weaver merged 1 commit intoDataDog:masterfrom
hvtuananh:gssapi

Conversation

@hvtuananh
Copy link
Contributor

What does this PR do?

This PR add --with-gssapi to the PostgreSQL configure step. krb5 1.20.1 is already built in the builder images, so this is a one-line change per platform.

Fixes #22742

Motivation

The previous agent used psycopg2-binary, which bundled its own libpq with GSSAPI and Kerberos libraries (libgssapi_krb5, libkrb5, libsasl2, etc.). The psycopg3 migration (PR #21173, v22.18.0) lost this.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 445c4aaa3a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

This PR add --with-gssapi to the PostgreSQL configure step.
krb5 1.20.1 is already built in the builder images, so this
is a one-line change per platform.

Fixes DataDog#22742
Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hvtuananh!

@eric-weaver eric-weaver added this pull request to the merge queue Mar 19, 2026
Merged via the queue into DataDog:master with commit 8b8d6b5 Mar 19, 2026
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PostgreSQL check fails with "GSSAPI authentication not supported" after Agent upgrade (psycopg2 → psycopg3)

4 participants