Skip to content

Increase message buffer size as a default and make it customizable#23029

Merged
steveny91 merged 13 commits intomasterfrom
sy/ibm-mq-issue
Apr 3, 2026
Merged

Increase message buffer size as a default and make it customizable#23029
steveny91 merged 13 commits intomasterfrom
sy/ibm-mq-issue

Conversation

@steveny91
Copy link
Copy Markdown
Contributor

What does this PR do?

The default buffer size for messages in IBM MQ is 4Kb. This PR increases it to 64Kb and make it configurable.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7cda4112aa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ibm_ace/datadog_checks/ibm_ace/subscription.py
Comment thread ibm_ace/tests/test_unit.py Outdated
no_msg_error = pymqi.MQMIError(pymqi.CMQC.MQCC_FAILED, pymqi.CMQC.MQRC_NO_MSG_AVAILABLE)

mock_sub = MagicMock()
mock_sub.get.side_effect = [truncation_error, no_msg_error]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prevent mock side_effect exhaustion in truncated-message test

This test configures mock_sub.get.side_effect with only two exceptions, but get_latest_messages() loops until 20 seconds elapse. Because the mocked calls return immediately, the loop performs a third get() call, exhausts the iterable side effect, and raises StopIteration, making the unit test fail nondeterministically instead of validating truncated-message handling.

Useful? React with 👍 / 👎.

@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official bot commented Mar 24, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c88849a | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

OliviaShoup
OliviaShoup previously approved these changes Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.04%. Comparing base (387f552) to head (c88849a).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed OliviaShoup’s stale review March 26, 2026 20:10

Review from OliviaShoup is dismissed. Related teams and files:

  • documentation
    • ibm_ace/assets/configuration/spec.yaml
@steveny91 steveny91 changed the title Increase message buffer size. Increase message buffer size as a default and make it customizable Mar 26, 2026
@steveny91 steveny91 added this pull request to the merge queue Apr 3, 2026
Merged via the queue into master with commit 09ea679 Apr 3, 2026
50 of 53 checks passed
@steveny91 steveny91 deleted the sy/ibm-mq-issue branch April 3, 2026 14:56
@dd-octo-sts dd-octo-sts bot added this to the 7.79.0 milestone Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants