[DBMON-6422] Remove internal user filtering in metrics for ClickHouse#23258
[DBMON-6422] Remove internal user filtering in metrics for ClickHouse#23258sangeetashivaji wants to merge 2 commits intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d440ce14a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| filters.append(f"user NOT IN ({users_list})") | ||
| return "AND " + " AND ".join(filters) | ||
|
|
||
| def _obfuscate_query(self, query_text: str) -> dict | None: |
There was a problem hiding this comment.
Removing _get_internal_user_filter from ClickhouseQueryLogJob breaks ClickhouseQueryCompletions._collect_completed_queries, which still calls self._get_internal_user_filter() when building COMPLETED_QUERIES_QUERY (query_completions.py, around lines 155-159). In any deployment with query completions enabled, this now raises AttributeError each collection cycle, preventing query-activity payload submission and effectively disabling that pipeline.
Useful? React with 👍 / 👎.
|
|
1 participant
What does this PR do?
As part of this PR we want the agent to allow capture of metrics for cloud internal user queries. We want users to be able to view all queries running on CH - both internal and application user queries.
The frontend will ensure proper grouping and filtering if users want to view this without creating noise
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged