DDS: Anomali ThreatStream: Threat Intel Integration v1.0.0#23345
DDS: Anomali ThreatStream: Threat Intel Integration v1.0.0#23345shubhamvekariya-crest wants to merge 6 commits intoDataDog:masterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efbb916408
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "tile": { | ||
| "overview": "README.md#Overview", | ||
| "configuration": "README.md#Setup", | ||
| "support": "README.md#Support", |
There was a problem hiding this comment.
Point tile support link to an existing README section
The manifest sets tile.support to README.md#Support, but this README does not define a ## Support heading (it only has ## Troubleshooting). That makes the support link from the integration tile resolve to a non-existent anchor, so users cannot navigate directly to support guidance from the tile page. Please either change the anchor to an existing section (for example README.md#Troubleshooting) or add a matching ## Support heading.
Useful? React with 👍 / 👎.
jeff-morgan-dd
left a comment
There was a problem hiding this comment.
Thank you! Please see a couple of grammar/style guide edits inline.
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
jeff-morgan-dd
left a comment
There was a problem hiding this comment.
Thanks for these updates! I noticed a few more items in the README, then should be OK for approval.
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
What does this PR do?
This is a initial release PR of Anomali ThreatStream integration including all the required assets.
Integration Logo Source: https://cdn.prod.website-files.com/6453db2ad32b573c40a15c49/6627ff6e7f8cb72de4b695f6_Anomali-OpenGraph-2024.webp, https://cdn.prod.website-files.com/68228a4fdbfec3b02c9c5186/68228a4fdbfec3b02c9c565b_Anomali-Logo-White-2024-1200.webp
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged