Skip to content

DDS: Anomali ThreatStream: Threat Intel Integration v1.0.0#23345

Open
shubhamvekariya-crest wants to merge 6 commits intoDataDog:masterfrom
bhargavnariyanicrest:anomali-threatstream-assets-v1.0.0
Open

DDS: Anomali ThreatStream: Threat Intel Integration v1.0.0#23345
shubhamvekariya-crest wants to merge 6 commits intoDataDog:masterfrom
bhargavnariyanicrest:anomali-threatstream-assets-v1.0.0

Conversation

@shubhamvekariya-crest
Copy link
Copy Markdown
Contributor

What does this PR do?

This is a initial release PR of Anomali ThreatStream integration including all the required assets.

Integration Logo Source: https://cdn.prod.website-files.com/6453db2ad32b573c40a15c49/6627ff6e7f8cb72de4b695f6_Anomali-OpenGraph-2024.webp, https://cdn.prod.website-files.com/68228a4fdbfec3b02c9c5186/68228a4fdbfec3b02c9c565b_Anomali-Logo-White-2024-1200.webp

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: efbb916408

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread anomali_threatstream/manifest.json Outdated
"tile": {
"overview": "README.md#Overview",
"configuration": "README.md#Setup",
"support": "README.md#Support",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point tile support link to an existing README section

The manifest sets tile.support to README.md#Support, but this README does not define a ## Support heading (it only has ## Troubleshooting). That makes the support link from the integration tile resolve to a non-existent anchor, so users cannot navigate directly to support guidance from the tile page. Please either change the anchor to an existing section (for example README.md#Troubleshooting) or add a matching ## Support heading.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

@jeff-morgan-dd jeff-morgan-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please see a couple of grammar/style guide edits inline.

Comment thread anomali_threatstream/README.md Outdated
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
Copy link
Copy Markdown
Contributor

@jeff-morgan-dd jeff-morgan-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates! I noticed a few more items in the README, then should be OK for approval.

Comment thread anomali_threatstream/README.md Outdated
Comment thread anomali_threatstream/README.md Outdated
Comment thread anomali_threatstream/README.md Outdated
Comment thread anomali_threatstream/README.md Outdated
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants