Conversation
feece89 to
3638356
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: feece89a5f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: cd3428f | Docs | Datadog PR Page | Give us feedback! |
Monitor Template Quality Assessment52 monitors analyzed across 9 integrations.
Monitors with missing sections
|
c8f041a to
1872dd9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Generate metrics reporting the min, max and last_value of sequences. This will allow to monitor if a sequence is about to be exhausted. One issue is that users can't read a sequence's last value without SELECT permission on the sequence. This means a GRANT would be required for all sequences on all databases in order to allow the datadog agent user to read this last value. Instead, we rely on a new `pg_sequences` function in the datadog schema that will be owned by the Postgres user, and GRANT it to the datadog-agent user. This will allow the agent to access all sequences, present and future, without having to provide additional GRANT.
1872dd9 to
69d3b56
Compare
Validation ReportAll 20 validations passed. Show details
|
What does this PR do?
Generate metrics reporting the min, max and last_value of sequences. This will allow to monitor if a sequence is about to be exhausted.
Motivation
One issue is that users can't read a sequence's last value without SELECT permission on the sequence. This means a GRANT would be required for all sequences on all databases in order to allow the datadog agent user to read this last value.
Instead, we rely on a new
pg_sequencesfunction in the datadog schema that will be owned by the Postgres user, and GRANT it to the datadog-agent user. This will allow the agent to access all sequences, present and future, without having to provide additional GRANT.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged