Skip to content

Add Supported OS::AIX tag to AIX-bundled integrations#23484

Open
pgimalac wants to merge 10 commits intomasterfrom
pgimalac/aix-supported-os
Open

Add Supported OS::AIX tag to AIX-bundled integrations#23484
pgimalac wants to merge 10 commits intomasterfrom
pgimalac/aix-supported-os

Conversation

@pgimalac
Copy link
Copy Markdown
Member

@pgimalac pgimalac commented Apr 27, 2026

Summary

The Datadog Agent AIX package bundles the following Python checks. This PR adds Supported OS::AIX to their classifier_tags in manifest.json so the tile metadata accurately reflects AIX support:

  • openmetrics
  • ibm_mq
  • ibm_ace
  • ibm_db2
  • ibm_i
  • ibm_was
  • lparstats

Marks the checks bundled in the AIX datadog-agent package as supporting AIX:
openmetrics, ibm_mq, ibm_ace, ibm_db2, ibm_i, ibm_was, lparstats.
dd-agent-integrations-bot[bot] and others added 9 commits April 27, 2026 12:08
…pgimalac/aix-supported-os

# Conflicts:
#	.deps/resolved/linux-aarch64_3.13.txt
#	.deps/resolved/linux-x86_64_3.13.txt
#	.deps/resolved/macos-aarch64_3.13.txt
#	.deps/resolved/macos-x86_64_3.13.txt
#	.deps/resolved/windows-x86_64_3.13.txt
…pgimalac/aix-supported-os

# Conflicts:
#	.deps/resolved/linux-aarch64_3.13.txt
#	.deps/resolved/linux-x86_64_3.13.txt
#	.deps/resolved/macos-aarch64_3.13.txt
#	.deps/resolved/macos-x86_64_3.13.txt
#	.deps/resolved/windows-x86_64_3.13.txt
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 6, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@pgimalac pgimalac marked this pull request as ready for review May 6, 2026 09:17
@pgimalac pgimalac requested a review from a team as a code owner May 6, 2026 09:17
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91654d2eb8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ibm_ace/manifest.json
"Supported OS::Linux",
"Supported OS::Windows",
"Supported OS::macOS",
"Supported OS::AIX",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update release tooling before adding a fourth OS tag

When one of these checks is released, ddev release make updates the Agent requirements via get_agent_requirement_line, which still only knows linux, mac_os, and windows in PLATFORMS_TO_PY/ALL_PLATFORMS. Adding Supported OS::AIX to manifests that already list all three existing OSes makes the parsed platform set ['aix', 'linux', 'mac_os', 'windows'], so it no longer matches ALL_PLATFORMS and falls through to ManifestError("Can't parse the supported OS list..."); this blocks releases for the affected integrations unless the release mapping/logic is updated alongside the new classifier.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants