Add Supported OS::AIX tag to AIX-bundled integrations#23484
Add Supported OS::AIX tag to AIX-bundled integrations#23484
Conversation
a01e1c2 to
902c532
Compare
902c532 to
e6707a2
Compare
Marks the checks bundled in the AIX datadog-agent package as supporting AIX: openmetrics, ibm_mq, ibm_ace, ibm_db2, ibm_i, ibm_was, lparstats.
e6707a2 to
6be691e
Compare
…pgimalac/aix-supported-os # Conflicts: # .deps/resolved/linux-aarch64_3.13.txt # .deps/resolved/linux-x86_64_3.13.txt # .deps/resolved/macos-aarch64_3.13.txt # .deps/resolved/macos-x86_64_3.13.txt # .deps/resolved/windows-x86_64_3.13.txt
…pgimalac/aix-supported-os # Conflicts: # .deps/resolved/linux-aarch64_3.13.txt # .deps/resolved/linux-x86_64_3.13.txt # .deps/resolved/macos-aarch64_3.13.txt # .deps/resolved/macos-x86_64_3.13.txt # .deps/resolved/windows-x86_64_3.13.txt
Validation ReportAll 20 validations passed. Show details
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91654d2eb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "Supported OS::Linux", | ||
| "Supported OS::Windows", | ||
| "Supported OS::macOS", | ||
| "Supported OS::AIX", |
There was a problem hiding this comment.
Update release tooling before adding a fourth OS tag
When one of these checks is released, ddev release make updates the Agent requirements via get_agent_requirement_line, which still only knows linux, mac_os, and windows in PLATFORMS_TO_PY/ALL_PLATFORMS. Adding Supported OS::AIX to manifests that already list all three existing OSes makes the parsed platform set ['aix', 'linux', 'mac_os', 'windows'], so it no longer matches ALL_PLATFORMS and falls through to ManifestError("Can't parse the supported OS list..."); this blocks releases for the affected integrations unless the release mapping/logic is updated alongside the new classifier.
Useful? React with 👍 / 👎.
Summary
The Datadog Agent AIX package bundles the following Python checks. This PR adds
Supported OS::AIXto theirclassifier_tagsinmanifest.jsonso the tile metadata accurately reflects AIX support:openmetricsibm_mqibm_aceibm_db2ibm_iibm_waslparstats