DDS: SpyCloud: Threat Intel Integration v1.0.0#23510
DDS: SpyCloud: Threat Intel Integration v1.0.0#23510jaypatel7-crest wants to merge 9 commits intoDataDog:masterfrom
Conversation
domalessi
left a comment
There was a problem hiding this comment.
Left a few suggestions. Tag me or re-request review when ready for another look!
| - IP | ||
| - Domain | ||
|
|
||
| Integrate SpyCloud with Datadog to enhance your security logs with threat intelligence, enabling analysis of matched IOCs through pre-built dashboards. Additionally, the integration can be used for Cloud SIEM detection rules for enhanced monitoring and security. |
There was a problem hiding this comment.
Tightening:
| Integrate SpyCloud with Datadog to enhance your security logs with threat intelligence, enabling analysis of matched IOCs through pre-built dashboards. Additionally, the integration can be used for Cloud SIEM detection rules for enhanced monitoring and security. | |
| Integrate SpyCloud with Datadog to enrich your security logs with threat intelligence and analyze matched IOCs through pre-built dashboards. The integration also feeds Cloud SIEM detection rules. |
|
|
||
| ## Setup | ||
|
|
||
| ### Obtain an API Key from SpyCloud Platform |
There was a problem hiding this comment.
Headings use sentence case. Also, this heading says "SpyCloud Platform" but step 1 below points users to the "SpyCloud Customer Portal" — let's keep them consistent.
| ### Obtain an API Key from SpyCloud Platform | |
| ### Obtain an API key from the SpyCloud Customer Portal |
There was a problem hiding this comment.
Updated the PR.
|
|
||
| ### Connect your SpyCloud account to Datadog | ||
|
|
||
| 1. Provide following details. |
There was a problem hiding this comment.
Missing article ("the") and use a colon to introduce the table.
| 1. Provide following details. | |
| 1. Provide the following details: |
There was a problem hiding this comment.
Updated the PR.
| | Parameter | Description | | ||
| | ---------- | ---------------------------------------------- | | ||
| | API Key | The API Key of your SpyCloud account. | | ||
| | Collect IP IOCs | Enable to collect IP IOCs. The default value is true. | |
There was a problem hiding this comment.
"The default value is true" reads like a config-file value, but in the UI this is a toggle. Suggest "Enabled by default" for clarity.
| | Collect IP IOCs | Enable to collect IP IOCs. The default value is true. | | |
| | Collect IP IOCs | Enable to collect IP IOCs. Enabled by default. | |
| | ---------- | ---------------------------------------------- | | ||
| | API Key | The API Key of your SpyCloud account. | | ||
| | Collect IP IOCs | Enable to collect IP IOCs. The default value is true. | | ||
| | Collect Domain IOCs | Enable to collect Domain IOCs. The default value is true. | |
There was a problem hiding this comment.
Same wording fix as above.
| | Collect Domain IOCs | Enable to collect Domain IOCs. The default value is true. | | |
| | Collect Domain IOCs | Enable to collect Domain IOCs. Enabled by default. | |
|
|
||
| ## Troubleshooting | ||
|
|
||
| Need help? Contact [Datadog support](https://docs.datadoghq.com/help/). No newline at end of file |
There was a problem hiding this comment.
Double space between "Contact" and the link.
| Need help? Contact [Datadog support](https://docs.datadoghq.com/help/). | |
| Need help? Contact [Datadog support](https://docs.datadoghq.com/help/). |
There was a problem hiding this comment.
Thanks for the fixes! Left some more tweaks inline, but should be good to go after that. Two high-level things:
Consider adding a brief Data Collected note
This integration doesn't submit metrics, service checks, or events, so it doesn't need the full Data Collected section from the standard template. That said, the convention is to state explicitly that none are collected, for example:
## Data Collected
The SpyCloud integration does not include any metrics, service checks, or events.
Optional, but it makes the README consistent with other integrations and answers a question users often ask.
display_on_public_website: false
Flagging this for awareness — the integration is not yet rendering on the public docs site. If that's intentional for this initial release, no action needed; just confirming we haven't missed flipping it.
|
|
||
| 1. Log in to your SpyCloud Customer Portal. | ||
| 2. Navigate to the **API** tab in the sidebar. | ||
| 3. In the **Keys** section, copy the **API Key**. |
There was a problem hiding this comment.
Datadog style uses lowercase "API key" since it's not a proper noun. (Same applies in line 23.)
| 3. In the **Keys** section, copy the **API Key**. | |
| 3. In the **Keys** section, copy the **API key**. |
| 1. Provide the following details: | ||
| | Parameter | Description | | ||
| | ---------- | ---------------------------------------------- | | ||
| | API Key | The API Key of your SpyCloud account. | |
There was a problem hiding this comment.
Lowercase "API key". Also, "for your account" reads more naturally than "of your account".
| | API Key | The API Key of your SpyCloud account. | | |
| | API key | The API key for your SpyCloud account. | |
|
|
||
| ### Connect your SpyCloud account to Datadog | ||
|
|
||
| 1. Provide the following details: |
There was a problem hiding this comment.
Step 1 doesn't tell the user where they are. Add a brief orienting phrase so it's clear they should be on the SpyCloud integration tile in Datadog.
| 1. Provide the following details: | |
| 1. In Datadog, on the SpyCloud integration tile, provide the following details: |
| | Parameter | Description | | ||
| | ---------- | ---------------------------------------------- | | ||
| | API Key | The API Key of your SpyCloud account. | | ||
| | Collect IP IOCs | Enable to collect IP IOCs. Enabled by default. | |
There was a problem hiding this comment.
The description "Enable to collect IP IOCs" repeats the parameter name. "Whether to..." is a clearer pattern for a toggle setting.
| | Collect IP IOCs | Enable to collect IP IOCs. Enabled by default. | | |
| | Collect IP IOCs | Whether to collect IP IOCs from SpyCloud. Enabled by default. | |
| | ---------- | ---------------------------------------------- | | ||
| | API Key | The API Key of your SpyCloud account. | | ||
| | Collect IP IOCs | Enable to collect IP IOCs. Enabled by default. | | ||
| | Collect Domain IOCs | Enable to collect Domain IOCs. Enabled by default. | |
There was a problem hiding this comment.
Same rephrase as the row above.
| | Collect Domain IOCs | Enable to collect Domain IOCs. Enabled by default. | | |
| | Collect Domain IOCs | Whether to collect domain IOCs from SpyCloud. Enabled by default. | |
| { | ||
| "id": 5986136339683419, | ||
| "definition": { | ||
| "title": "CRITICALs", |
There was a problem hiding this comment.
Sentence case for widget titles.
Also, pluralizing all-caps tokens with a lowercase "s" ("CRITICALs") is grammatically awkward. Same applies to lines 1437, 1561, 1614, and 1667 (separate suggestions on each).
| "title": "CRITICALs", | |
| "title": "Critical signals", |
| { | ||
| "id": 6559980888525287, | ||
| "definition": { | ||
| "title": "HIGHs", |
There was a problem hiding this comment.
| "title": "HIGHs", | |
| "title": "High signals", |
| { | ||
| "id": 2114682197371367, | ||
| "definition": { | ||
| "title": "MEDIUMs", |
There was a problem hiding this comment.
| "title": "MEDIUMs", | |
| "title": "Medium signals", |
| { | ||
| "id": 1150500876952374, | ||
| "definition": { | ||
| "title": "LOWs", |
There was a problem hiding this comment.
| "title": "LOWs", | |
| "title": "Low signals", |
| { | ||
| "id": 3077932004771300, | ||
| "definition": { | ||
| "title": "INFOs", |
There was a problem hiding this comment.
| "title": "INFOs", | |
| "title": "Info signals", |
domalessi
left a comment
There was a problem hiding this comment.
A few nits I missed last time but this is looking good! Approving so you're not blocked on me :)
| { | ||
| "id": 6044605789288649, | ||
| "definition": { | ||
| "title": "Critical Security Signals", |
There was a problem hiding this comment.
| "title": "Critical Security Signals", | |
| "title": "Critical security signals", |
| { | ||
| "id": 1784805821887938, | ||
| "definition": { | ||
| "title": "High Security Signals", |
There was a problem hiding this comment.
| "title": "High Security Signals", | |
| "title": "High security signals", |
| { | ||
| "id": 6427496511993500, | ||
| "definition": { | ||
| "title": "Medium Security Signals", |
There was a problem hiding this comment.
| "title": "Medium Security Signals", | |
| "title": "Medium security signals", |
| - IP | ||
| - Domain | ||
|
|
||
| Integrate SpyCloud with Datadog to enrich your security logs with threat intelligence and analyze matched IOCs through pre-built dashboards. The integration also feeds Cloud SIEM detection rules. |
There was a problem hiding this comment.
| Integrate SpyCloud with Datadog to enrich your security logs with threat intelligence and analyze matched IOCs through pre-built dashboards. The integration also feeds Cloud SIEM detection rules. | |
| Integrate SpyCloud with Datadog to enrich your security logs with threat intelligence and analyze matched indicators of compromise (IOCs) through pre-built dashboards. The integration also feeds Cloud SIEM detection rules. |
What does this PR do?
This is a initial release PR of SpyCloud integration including all the required assets.
Integration Logo Source
Light Theme: https://spycloud.com/wp-content/uploads/2025/04/SpyCloud-Logo-Black-1.svg
Dark Theme: https://portal.spycloud.com/images/Logo-Reversed.png
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged