Skip to content

[Dispatcher] Task Test Runner#23518

Open
HadhemiDD wants to merge 5 commits intomasterfrom
hs/dispatcher-test-runner
Open

[Dispatcher] Task Test Runner#23518
HadhemiDD wants to merge 5 commits intomasterfrom
hs/dispatcher-test-runner

Conversation

@HadhemiDD
Copy link
Copy Markdown
Contributor

What does this PR do?

Create the processor as described here

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 29, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e920df3a4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

json=body,
)
return GitHubResponse[None].model_validate({"data": None, "headers": dict(response.headers)})
return self._parse_response(response, WorkflowDispatchResult)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Request run details before parsing dispatch response

create_workflow_dispatch now unconditionally parses the response body as WorkflowDispatchResult, but GitHub’s workflow dispatch endpoint only returns JSON when return_run_details=true; otherwise it still returns 204 No Content. In that default/legacy path (including older API versions and GHES), response.json() raises and the dispatcher fails before any polling starts, so TaskTestRunner.process_message cannot run. Please either send return_run_details: true in the request body or keep backward-compatible handling for 204 responses.

Useful? React with 👍 / 👎.

@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 Bot commented Apr 29, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 96.00%
Overall Coverage: 87.31% (+0.18%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 02e13e0 | Docs | Datadog PR Page | Give us feedback!

@HadhemiDD HadhemiDD added the qa/skip-qa Automatically skip this PR for the next QA label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 96.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.81%. Comparing base (df5b219) to head (02e13e0).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HadhemiDD HadhemiDD force-pushed the hs/dispatcher-test-runner branch from 19bd322 to 2cdcfbd Compare April 30, 2026 11:04
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 30, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant