Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e920df3a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| json=body, | ||
| ) | ||
| return GitHubResponse[None].model_validate({"data": None, "headers": dict(response.headers)}) | ||
| return self._parse_response(response, WorkflowDispatchResult) |
There was a problem hiding this comment.
Request run details before parsing dispatch response
create_workflow_dispatch now unconditionally parses the response body as WorkflowDispatchResult, but GitHub’s workflow dispatch endpoint only returns JSON when return_run_details=true; otherwise it still returns 204 No Content. In that default/legacy path (including older API versions and GHES), response.json() raises and the dispatcher fails before any polling starts, so TaskTestRunner.process_message cannot run. Please either send return_run_details: true in the request body or keep backward-compatible handling for 204 responses.
Useful? React with 👍 / 👎.
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 02e13e0 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
19bd322 to
2cdcfbd
Compare
Validation ReportAll 20 validations passed. Show details
|
What does this PR do?
Create the processor as described here
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged