Skip to content

apply security format refs to template configuration YAMLs#23540

Draft
san-jos wants to merge 6 commits intomasterfrom
sandra.josy/fa-sync-format-refs
Draft

apply security format refs to template configuration YAMLs#23540
san-jos wants to merge 6 commits intomasterfrom
sandra.josy/fa-sync-format-refs

Conversation

@san-jos
Copy link
Copy Markdown
Contributor

@san-jos san-jos commented Apr 30, 2026

Summary

  • Replaces secret: true with formats: ["secret"] in template YAMLs (http, jmx, tls, pdh_legacy, perf_counters)

  • Adds formats: ["path"] to TLS cert/CA cert fields in http and tls templates

  • Adds formats: ["tag"] to tags items in the tags template and kubernetes_state_core spec

  • Adds formats: ["url"] to prometheus_url in openmetrics_legacy_base

  • Add secret and tag to allowed format

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented Apr 30, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 65.21%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bc8cb88 | Docs | Datadog PR Page | Give us feedback!

@san-jos san-jos force-pushed the sandra.josy/fa-sync-format-refs branch from ce9c886 to cb09a3d Compare May 5, 2026 14:48
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.04%. Comparing base (0e82485) to head (bc8cb88).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

san-jos and others added 2 commits May 6, 2026 13:08
Per review feedback, keep the existing `secret: true` field while still
adding the security format ref so both the legacy flag and format-based
validation apply.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 7, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@san-jos san-jos requested a review from coignetp May 7, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants