Update recommended monitor templates to not use notify_no_data#23615
Update recommended monitor templates to not use notify_no_data#23615
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 893c216afc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "options": { | ||
| "include_tags": false, | ||
| "no_data_timeframe": 10, | ||
| "on_missing_data": "default", |
There was a problem hiding this comment.
Preserve no-data status for non-notifying monitors
For monitors that previously had notify_no_data: false, this should migrate to on_missing_data: "show_no_data" rather than "default": Datadog's migration guide maps the legacy “Do not notify if data is missing” behavior to show_no_data, while default evaluates missing sum/count data as zero or keeps the last status for other aggregations. As written, this OpenAI monitor (and the two WebLogic monitors changed the same way) will no longer enter No Data when the integration stops reporting, hiding missing telemetry from monitor status/SLO consumers even though the old template surfaced it without paging.
Useful? React with 👍 / 👎.
Validation ReportAll 20 validations passed. Show details
|
notify_no_datais being replaced byon_missing_data, so I'm updating all templates that are still using the old format