Skip to content

Update recommended monitor templates to not use notify_no_data#23615

Open
zgarciadd wants to merge 1 commit intomasterfrom
zdg/fix_notify_no_data
Open

Update recommended monitor templates to not use notify_no_data#23615
zgarciadd wants to merge 1 commit intomasterfrom
zdg/fix_notify_no_data

Conversation

@zgarciadd
Copy link
Copy Markdown

notify_no_data is being replaced by on_missing_data, so I'm updating all templates that are still using the old format

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 6, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 893c216afc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

"options": {
"include_tags": false,
"no_data_timeframe": 10,
"on_missing_data": "default",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve no-data status for non-notifying monitors

For monitors that previously had notify_no_data: false, this should migrate to on_missing_data: "show_no_data" rather than "default": Datadog's migration guide maps the legacy “Do not notify if data is missing” behavior to show_no_data, while default evaluates missing sum/count data as zero or keeps the last status for other aggregations. As written, this OpenAI monitor (and the two WebLogic monitors changed the same way) will no longer enter No Data when the integration stops reporting, hiding missing telemetry from monitor status/SLO consumers even though the old template surfaced it without paging.

Useful? React with 👍 / 👎.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 6, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants