Skip to content

Added the pod level resources to the metadata.csv#23847

Merged
sehgal23 merged 1 commit into
masterfrom
arnav.sehgal/contint-5329/pod-level-resource-info
May 27, 2026
Merged

Added the pod level resources to the metadata.csv#23847
sehgal23 merged 1 commit into
masterfrom
arnav.sehgal/contint-5329/pod-level-resource-info

Conversation

@sehgal23
Copy link
Copy Markdown
Contributor

What does this PR do?

I added the pod level resources to the metadata.csv. Some of which include:

  • kubernetes.pod.cpu.request
  • kubernetes.pod.cpu.limit
  • kubernetes.pod.memory.request
  • kubernetes.pod.memory.limit

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 676ef073ba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread kubelet/metadata.csv
Comment on lines +18 to +19
kubernetes.pod.cpu.request,gauge,,core,,The pod-level requested CPU cores,0,kubernetes,k8s.pod.cpu.request,
kubernetes.pod.cpu.limit,gauge,,core,,The pod-level CPU core limit,0,kubernetes,k8s.pod.cpu.limit,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove metrics that the kubelet check never emits

For clusters that set Kubernetes pod-level resources, these new kubernetes.pod.* rows advertise metrics that the kubelet integration cannot currently submit: _report_container_spec_metrics only iterates pod.spec.containers/initContainers and emits gauges named kubernetes.<resource>.requests or .limits, so pod.spec.resources is ignored and names like kubernetes.pod.cpu.request/limit never appear. This will make the generated metadata/docs list metrics users cannot receive unless collection support is added alongside the metadata.

Useful? React with 👍 / 👎.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.05%. Comparing base (b5362c7) to head (676ef07).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented May 27, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. PR #23847 is missing a required QA decision label. Must set 'qa/required' or 'qa/skip-qa'.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 91.09% (+3.69%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 676ef07 | Docs | Datadog PR Page | Give us feedback!

@sehgal23 sehgal23 added the qa/skip-qa Automatically skip this PR for the next QA label May 27, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 27, 2026

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@sehgal23 sehgal23 added this pull request to the merge queue May 27, 2026
Merged via the queue into master with commit e2f996e May 27, 2026
74 of 87 checks passed
@sehgal23 sehgal23 deleted the arnav.sehgal/contint-5329/pod-level-resource-info branch May 27, 2026 17:51
@dd-octo-sts dd-octo-sts Bot added this to the 7.81.0 milestone May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants