Added the pod level resources to the metadata.csv#23847
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 676ef073ba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| kubernetes.pod.cpu.request,gauge,,core,,The pod-level requested CPU cores,0,kubernetes,k8s.pod.cpu.request, | ||
| kubernetes.pod.cpu.limit,gauge,,core,,The pod-level CPU core limit,0,kubernetes,k8s.pod.cpu.limit, |
There was a problem hiding this comment.
Remove metrics that the kubelet check never emits
For clusters that set Kubernetes pod-level resources, these new kubernetes.pod.* rows advertise metrics that the kubelet integration cannot currently submit: _report_container_spec_metrics only iterates pod.spec.containers/initContainers and emits gauges named kubernetes.<resource>.requests or .limits, so pod.spec.resources is ignored and names like kubernetes.pod.cpu.request/limit never appear. This will make the generated metadata/docs list metrics users cannot receive unless collection support is added alongside the metadata.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
|
Validation ReportAll 21 validations passed. Show details
|
What does this PR do?
I added the pod level resources to the metadata.csv. Some of which include:
Motivation
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged