Skip to content

[rabbitmq] [rabbitmq] Add metric for unbalanced queue masters#23874

Draft
mahipdeora25 wants to merge 1 commit into
masterfrom
fbo/ae5375ff-rabbitmq-add-metric-for-unbalanced-queue
Draft

[rabbitmq] [rabbitmq] Add metric for unbalanced queue masters#23874
mahipdeora25 wants to merge 1 commit into
masterfrom
fbo/ae5375ff-rabbitmq-add-metric-for-unbalanced-queue

Conversation

@mahipdeora25
Copy link
Copy Markdown
Contributor

Generated by FBO — DRAFT for human review

Closes FRAGENT-1039

Reality-check reasoning

There is no metric related to queue masters or unbalanced queue masters in the integration. The QUEUE_ATTRIBUTES list in const.py defines all queue metrics collected — it covers consumers, messages, memory, rates, etc., but contains no node/master tracking fields like synchronised_slave_nodes, slave_nodes, or any "queue master" balance metric. The metadata.csv (329 metrics) was scanned and shows no master or unbalanced metric names. The FR asks for a new metric derived from RabbitMQ's HA/mirroring API (https://www.rabbitmq.com/ha.html) that would detect uneven distribution of queue masters across nodes — this logic does not exist anywhere in the current check code.

Learned from exemplar PRs: #20174, #19401, #19536, #20697, #23457

This PR was opened as a Draft. A human should review the diff,
re-run validators if needed, and mark Ready for Review.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026

Validation Report

Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented May 28, 2026

Pipelines  Tests  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

Check PR | run / Check PR changelog   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Package "rabbitmq" has changes that require a changelog. Please run `ddev release changelog new` to add it.

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Missing QA decision label for PR #23874. The PR must declare if it requires QA validation with 'qa/required' or 'qa/skip-qa'.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 95.43% (+8.05%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 258954d | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant