Parameterize SQL Server agent history row limit

[lu-zhengda]

What does this PR do?

Parameterizes the SQL Server Agent job history row limit by changing the query to use SELECT TOP (?) and executing it with (history_row_limit, last_collection_time). It also removes duplicated test SQL so the tests execute the production AGENT_HISTORY_QUERY directly.

Motivation

Follow-up to #24203. That PR stabilized the changing completion_epoch_time filter; this removes the remaining query text formatting for the configurable history_row_limit so both dynamic query inputs are bound parameters.

Validation so far:

• ddev --no-interactive test -fs sqlserver
• ddev --no-interactive test sqlserver:py3.13-linux-odbc-2022-single -- -k test_agent_history_query_parameterizes_last_collection_time

I also attempted test_connection_with_agent_history locally to exercise TOP (?) against SQL Server, but the local Docker SQL Server container failed before query execution with initerrlog: Could not open error log file '/var/opt/mssql/log/errorlog'. Operating system error = 5(Access is denied.).

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
• If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

[datadog-prod-us1-5]

 

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 90.40% (+2.44%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c4f2c23 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Validation Report

All 21 validations passed.

Show details

Validation	Description	Status
agent-reqs	Verify check versions match the Agent requirements file	✅
ci	Validate CI configuration and code coverage settings	✅
codeowners	Validate every integration has a CODEOWNERS entry	✅
config	Validate default configuration files against spec.yaml	✅
dep	Verify dependency pins are consistent and Agent-compatible	✅
http	Validate integrations use the HTTP wrapper correctly	✅
imports	Validate check imports do not use deprecated modules	✅
integration-style	Validate check code style conventions	✅
jmx-metrics	Validate JMX metrics definition files and config	✅
labeler	Validate PR labeler config matches integration directories	✅
legacy-signature	Validate no integration uses the legacy Agent check signature	✅
license-headers	Validate Python files have proper license headers	✅
licenses	Validate third-party license attribution list	✅
metadata	Validate metadata.csv metric definitions	✅
models	Validate configuration data models match spec.yaml	✅
openmetrics	Validate OpenMetrics integrations disable the metric limit	✅
package	Validate Python package metadata and naming	✅
qa-label	Validate the pull request declares whether it needs QA for the next Agent release	✅
readmes	Validate README files have required sections	✅
saved-views	Validate saved view JSON file structure and fields	✅
version	Validate version consistency between package and changelog	✅

View full run