Mark slurm seff_path as require_trusted_provider#24235
Merged
Merged
Conversation
The seff binary path is resolved from the seff_path instance config and used as argv[0] in subprocess.run, but seff_path was never declared in the config spec, so it had no trusted-provider guard like the other binary path fields. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c2c47c7 | Docs | Datadog PR Page | Give us feedback! |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Validation ReportAll 21 validations passed. Show details
|
dkirov-dd
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
seff_pathinstance config field to the Slurm integration spec and marks it withrequire_trusted_provider: true, matching the other binary path fields (sinfo_path,sacct_path,sdiag_path,sshare_path,squeue_path,scontrol_path) and theslurm_binaries_dirinit_config field.Motivation
https://datadoghq.atlassian.net/browse/VULN-81302
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged