Skip to content

Mark slurm seff_path as require_trusted_provider#24235

Merged
NouemanKHAL merged 4 commits into
masterfrom
noueman/slurm-seff-path-trusted-provider
Jun 29, 2026
Merged

Mark slurm seff_path as require_trusted_provider#24235
NouemanKHAL merged 4 commits into
masterfrom
noueman/slurm-seff-path-trusted-provider

Conversation

@NouemanKHAL

@NouemanKHAL NouemanKHAL commented Jun 29, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Adds the seff_path instance config field to the Slurm integration spec and marks it with require_trusted_provider: true, matching the other binary path fields (sinfo_path, sacct_path, sdiag_path, sshare_path, squeue_path, scontrol_path) and the slurm_binaries_dir init_config field.

Motivation

https://datadoghq.atlassian.net/browse/VULN-81302

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

The seff binary path is resolved from the seff_path instance config
and used as argv[0] in subprocess.run, but seff_path was never declared
in the config spec, so it had no trusted-provider guard like the other
binary path fields.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@NouemanKHAL NouemanKHAL added the qa/skip-qa Automatically skip this PR for the next QA label Jun 29, 2026
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 92.56% (+3.38%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c2c47c7 | Docs | Datadog PR Page | Give us feedback!

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@NouemanKHAL NouemanKHAL marked this pull request as ready for review June 29, 2026 09:10
@NouemanKHAL NouemanKHAL requested review from a team as code owners June 29, 2026 09:10
@dd-octo-sts

dd-octo-sts Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@NouemanKHAL NouemanKHAL added this pull request to the merge queue Jun 29, 2026
Merged via the queue into master with commit a88e970 Jun 29, 2026
56 checks passed
@NouemanKHAL NouemanKHAL deleted the noueman/slurm-seff-path-trusted-provider branch June 29, 2026 12:31
@dd-octo-sts dd-octo-sts Bot added this to the 7.82.0 milestone Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants