Skip to content

Fix typo and type for pulsar.broker_lookup.quantile in metadata.csv#24258

Merged
martavicentenavarro merged 7 commits into
masterfrom
fix/pulsar-broker-lookup-quantile-typo
Jun 30, 2026
Merged

Fix typo and type for pulsar.broker_lookup.quantile in metadata.csv#24258
martavicentenavarro merged 7 commits into
masterfrom
fix/pulsar-broker-lookup-quantile-typo

Conversation

@martavicentenavarro

@martavicentenavarro martavicentenavarro commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes two pre-existing bugs on line 33 of pulsar/metadata.csv:

  • Typo: pulsar.broker_lookup.quantlepulsar.broker_lookup.quantile (missing i)
  • Wrong type: countgauge (summary quantiles are submitted as gauge by the OpenMetrics transformer, see datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/transformers/summary.py)

Motivation

The typo was introduced in the original Pulsar integration and went undetected because test_check does not use assert_metrics_using_metadata. It was discovered while adding config discovery support (#24116), where test_e2e_discovery calls assert_metrics_using_metadata and fails whenever Pulsar emits the quantile metric during the CI run.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • qa/skip-qa

The metric was misspelled as `quantle` and typed as `count`. Summary
quantiles are submitted as gauge by the OpenMetrics transformer.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 30, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 100.00% (+11.99%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 33d1194 | Docs | Datadog PR Page | Give us feedback!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Pulsar metric metadata so the broker lookup summary quantile metric is correctly named and typed, aligning the integration’s metric catalog with what the OpenMetrics v2 summary transformer actually submits.

Changes:

  • Correct metric name typo: pulsar.broker_lookup.quantlepulsar.broker_lookup.quantile.
  • Update metric type for the summary quantile series from count to gauge.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pulsar/metadata.csv Outdated
martavicentenavarro and others added 2 commits June 30, 2026 14:36
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@martavicentenavarro martavicentenavarro added the assets/no-deploy Prevents APW from deploying this PR in staging label Jun 30, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@martavicentenavarro martavicentenavarro added this pull request to the merge queue Jun 30, 2026
Merged via the queue into master with commit 42d081b Jun 30, 2026
52 checks passed
@martavicentenavarro martavicentenavarro deleted the fix/pulsar-broker-lookup-quantile-typo branch June 30, 2026 16:37
@dd-octo-sts dd-octo-sts Bot added this to the 7.82.0 milestone Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants