Fix typo and type for pulsar.broker_lookup.quantile in metadata.csv#24258
Merged
martavicentenavarro merged 7 commits intoJun 30, 2026
Conversation
The metric was misspelled as `quantle` and typed as `count`. Summary quantiles are submitted as gauge by the OpenMetrics transformer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 33d1194 | Docs | Datadog PR Page | Give us feedback! |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Pulsar metric metadata so the broker lookup summary quantile metric is correctly named and typed, aligning the integration’s metric catalog with what the OpenMetrics v2 summary transformer actually submits.
Changes:
- Correct metric name typo:
pulsar.broker_lookup.quantle→pulsar.broker_lookup.quantile. - Update metric type for the summary quantile series from
counttogauge.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dkirov-dd
approved these changes
Jun 30, 2026
evazorro
approved these changes
Jun 30, 2026
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two pre-existing bugs on line 33 of
pulsar/metadata.csv:pulsar.broker_lookup.quantle→pulsar.broker_lookup.quantile(missingi)count→gauge(summary quantiles are submitted as gauge by the OpenMetrics transformer, seedatadog_checks_base/datadog_checks/base/checks/openmetrics/v2/transformers/summary.py)Motivation
The typo was introduced in the original Pulsar integration and went undetected because
test_checkdoes not useassert_metrics_using_metadata. It was discovered while adding config discovery support (#24116), wheretest_e2e_discoverycallsassert_metrics_using_metadataand fails whenever Pulsar emits the quantile metric during the CI run.Review checklist (to be filled by reviewers)
qa/skip-qa