Define dataflows for saas-integrations-owned integrations - #3103
Open
philjlee wants to merge 1 commit into
Open
Conversation
Split of #3093 by CODEOWNERS team. Jira: TXP-277
There was a problem hiding this comment.
More details
The added YugabyteDB Managed dataflow accurately describes the integration's metrics-only inbound export and matches the repository's established dataflow conventions. Executable YAML validation covered the candidate, all 15 repository fixtures, and five malformed-shape cases; the repository's ddev validator could not run because ddev is not installed in the sandbox.
📊 Validated against 21 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit e9248d8 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: TXP-277
Adds
assets/dataflows.yamlto 1 integration owned by@DataDog/saas-integrations, declaring 1 dataflow. Mechanical change: no code, no metrics, no manifests touched.Precedent: #2925 "Define dataflows for saas-integrations", which created 13 of the 14 existing dataflow files in this repo.
Selection criteria
A directory is in this batch only if all of the following hold:
assets/dataflows.yamltoday.manifest.json. The dataflows validator hard-requires one —dataflows_validation_handler.go:56.data_typeis mechanically derivable from a committed artifact, with no judgement call:metadata.csvwith at least one data row →metricsassets/logs/*.yaml→logs.github/CODEOWNERSresolves<dir>/assets/dataflows.yaml(last-match-wins) to an owner set containing@DataDog/saas-integrations.yugabytedb_managed/has@DataDog/saas-integrationsas a Datadog team CODEOWNER (co-owned with@DataDog/ecosystems-review; grouped here since it's the more specific/smaller of the two teams), so review from@DataDog/saas-integrationscovers this PR.Field values
always_on: true/granular: false/direction: inboundmatches 14 of the 17 dataflow entries already in the repo. The only deviation in the repo isvercel, which isalways_on: falsefor a Serverless product-enablement reason that does not apply here.The dataflow ID is
<app_id>-<data_type>, takingapp_idfrommanifest.jsonrather than the directory name. It was checked for collisions against every existing ID in the repo.Validation
This file was validated by executing the real validator,
DataflowsValidationHandlerfromdd-source/domains/integrationscatalog/libs/catalogassetslib/dataflows_validation_handler.go, atddoghq/dd-source@main, against everydataflows.yamlfile in the repo working tree with this PR applied. Result: 0 failures, covering per-file unmarshalling, proto constraint validation, and the cross-fileHandleLibraryID-uniqueness check.The harness was negative-tested first and confirmed to reject: a missing
always_on; adata_typeoutsidevalidDataTypes; anidbreaking^[a-z0-9-]+$; anidunder 3 characters; a file with neitherprovidesnoruses; a.ymlextension; a missingmanifest.json; and the same dataflow ID provided by two apps.This matters because APW does not post validator comments on integrations-extras PRs (
enable_validator_commentsis set only forpub-platform-stagingandpublishing-platform). A malformeddataflows.yamlmerges cleanly here and only fails afterwards, in the shared asset pipeline.Contents
Metrics only (1)
yugabytedb_managedyugabytedb-managed-metrics🤖 Generated with Claude Code