Fix ping check with bad float conversion - #818
Merged
Merged
Conversation
ChristineTChen
approved these changes
Mar 4, 2021
eliadeini
pushed a commit
to eliadeini/integrations-extras
that referenced
this pull request
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the
pingcheck casts the timeout parameter to float.this result in running an invalid ping command
unfortunately the type casting is hardcoded in the check code.
I have tested on linux (debian), Darwin and Windows and it seams ok to use
intinsteadMotivation
What inspired you to submit this pull request?
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?