Ping on Windows - Set codepage to English - #992
Merged
Conversation
On non-US Windows, output of the ping.exe is localized. It breaks the ping check and results in error. To avoid this, I added the code to set the code page to English. chcp and code page: https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/chcp
adjusted styles
adjusted styles
ChristineTChen
suggested changes
Sep 16, 2021
ChristineTChen
left a comment
ChristineTChen
left a comment
Contributor
There was a problem hiding this comment.
thanks for the PR. I left a comment just to clean up the code a little bit. I'll still wait on merging until the maintainer has had a chance to review.
Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com>
Contributor
Author
|
Thanks @ChristineTChen ! I cleaned up the codes. |
ChristineTChen
approved these changes
Sep 17, 2021
ChristineTChen
left a comment
ChristineTChen
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Pinging @jstanton617 as the maintainer for a look as well
Contributor
|
Hi @jstanton617 , quick follow up on my previous ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On non-US Windows, output of the ping.exe is localized.
It breaks the ping check and results in error.
To avoid this, I added the code to set the code page to English.
chcp and code page: docs
Motivation
Feedback and support tickets from users.
Review checklist
no-changeloglabel attached