chore: address release script#683
Merged
Merged
Conversation
kaahos
marked this pull request as ready for review
July 22, 2026 20:39
Contributor
CI Test ResultsRun: #29955864873 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-07-22 20:59:39 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
fixes
check_not_stuckso that a missing release tag is treated as the expected state for a new release.The check now uses
git show-ref --verify --quietwith the complete tag reference and returns success explicitly when the tag does not exist or the release is a dry run.Motivation:
With
set -e, the previousgit rev-parse ... || returnpropagated exit code 128 when the target tag did not exist. This aborted valid releases before tag creation.Additional Notes:
Existing tags still trigger the intended “branch is stuck” failure. Using the complete
refs/tags/...reference also ensures that only the exact tag is checked.An end-to-end release dry run can only be executed after merging because minor-release workflows require remote
main.How to test the change?:
bash -n .github/scripts/release.shgit diff --check origin/main...HEADcheck_not_stuckbehavior:For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.Unsure? Have a question? Request a review!