Skip to content

chore: address release script#683

Merged
kaahos merged 1 commit into
mainfrom
paul.fournillon/fix-release-tag-check
Jul 23, 2026
Merged

chore: address release script#683
kaahos merged 1 commit into
mainfrom
paul.fournillon/fix-release-tag-check

Conversation

@kaahos

@kaahos kaahos commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?:

fixes check_not_stuck so that a missing release tag is treated as the expected state for a new release.

The check now uses git show-ref --verify --quiet with the complete tag reference and returns success explicitly when the tag does not exist or the release is a dry run.

Motivation:

With set -e, the previous git rev-parse ... || return propagated exit code 128 when the target tag did not exist. This aborted valid releases before tag creation.

Additional Notes:

Existing tags still trigger the intended “branch is stuck” failure. Using the complete refs/tags/... reference also ensures that only the exact tag is checked.

An end-to-end release dry run can only be executed after merging because minor-release workflows require remote main.

How to test the change?:

  • bash -n .github/scripts/release.sh
  • git diff --check origin/main...HEAD
  • Verified check_not_stuck behavior:
    • Missing tag returns 0.
    • Existing tag returns 1 with the expected diagnostic.
    • Dry-run returns 0.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a security review (run the dd:platform-security-review
    skill, or file a request via the PSEC review form).
    bewaire also runs automatically on every PR.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

@kaahos
kaahos marked this pull request as ready for review July 22, 2026 20:39
@kaahos
kaahos requested a review from a team as a code owner July 22, 2026 20:39
@dd-octo-sts

dd-octo-sts Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #29955864873 | Commit: fb3ed74 | Duration: 14m 54s (longest job)

All 32 test jobs passed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - - -
8-ibm - - -
8-j9 - -
8-librca - -
8-orcl - - -
11 - - -
11-j9 - -
11-librca - -
17 - -
17-graal - -
17-j9 - -
17-librca - -
21 - -
21-graal - -
21-librca - -
25 - -
25-graal - -
25-librca - -

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-07-22 20:59:39 UTC

@jbachorik jbachorik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaahos
kaahos merged commit 61fcfb3 into main Jul 23, 2026
105 of 107 checks passed
@kaahos
kaahos deleted the paul.fournillon/fix-release-tag-check branch July 23, 2026 09:06
@github-actions github-actions Bot added this to the 1.47.0 milestone Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants