Register metrics where possible.#544
Merged
Merged
Conversation
GeorgeHahn
approved these changes
Apr 13, 2023
blt
added a commit
that referenced
this pull request
Apr 14, 2023
This commit pre-registers metrics in our blackholes, a peer to #544. I have made use of OnceCell in situations where a registered metrics needs to cross task boundaries. Fortunately in our blackholes we do not use labels in our metrics so this was a fairly total conversion. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
added a commit
that referenced
this pull request
Apr 17, 2023
This commit pre-registers metrics in our blackholes, a peer to #544. I have made use of OnceCell in situations where a registered metrics needs to cross task boundaries. Fortunately in our blackholes we do not use labels in our metrics so this was a fairly total conversion. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is an extraction from #539. The use of the metrics-rs macros are cheap but not free and we have been using them in hot loops. This commit pre-registers metrics with their labels before use, reducing that cost.
Related issues
REF SMP-463