Skip to content

feat(process-discovery): add process_tags and container_id to TracerMetadata#104

Merged
tlhunter merged 6 commits intomainfrom
tlhunter/process-tags-process-discovery
Mar 19, 2026
Merged

feat(process-discovery): add process_tags and container_id to TracerMetadata#104
tlhunter merged 6 commits intomainfrom
tlhunter/process-tags-process-discovery

Conversation

@tlhunter
Copy link
Copy Markdown
Member

@tlhunter tlhunter commented Mar 18, 2026

What does this PR do?

Adds two new fields to the process tracking metadata and upgrades the underlying version of libdatadog.

Motivation

https://github.com/DataDog/dd-trace-js/pull/7816/changes

Additional Notes

I'm getting a bunch of build errors about lacking binaries for certain platforms. The LLM decided to pin the version of prebuildify to fix it. I'm sure this isn't the right approach but I'm unfamiliar with the project and don't know the solution.

Running test/process-discovery.js
/__w/libdatadog-nodejs/libdatadog-nodejs/load.js:36
  throw new Error(`Could not find a ${name} binary for ${PLATFORM}${LIBC}-${ARCH} nor a ${name} WASM module.`)
  ^

Error: Could not find a process-discovery binary for linuxmusl-x64 nor a process-discovery WASM module.
    at Object.load (/__w/libdatadog-nodejs/libdatadog-nodejs/load.js:36:9)
    at Object.<anonymous> (/__w/libdatadog-nodejs/libdatadog-nodejs/test/process-discovery.js:8:38)
    at Module._compile (node:internal/modules/cjs/loader:1829:14)
    at Object..js (node:internal/modules/cjs/loader:1969:10)
    at Module.load (node:internal/modules/cjs/loader:1552:32)
    at Module._load (node:internal/modules/cjs/loader:1354:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
    at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
    at node:internal/main/run_main_module:33:47

Node.js v25.8.1
error Command failed with exit code 1.

…etadata

Bump libdatadog dependency from datadog-library-config v18.1.0 to
libdd-library-config v29.0.0 (which includes process_tags and container_id
in the TracerMetadata struct), and expose both new fields in the NAPI binding.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tlhunter tlhunter requested review from a team as code owners March 18, 2026 17:40
@tlhunter tlhunter marked this pull request as draft March 18, 2026 17:42
action-prebuildify@main was updated (2026-03-18) with a regression that
renames all RUST=true prebuilt .node files to the same destination
('node-napi.node'), causing multi-file artifacts to be overwritten.

Pin to the last working commit (d4e89247, 2026-03-16) until upstream
action-prebuildify is fixed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Overall package size

Self size: 36.05 MB
Deduped: 36.05 MB
No deduping: 36.05 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------|

🤖 This report was automatically generated by heaviest-objects-in-the-universe

…vert build.yml pin

Use Cargo's package alias to keep the existing dep name (datadog-library-config)
while upgrading to libdd-library-config v29.0.0, which includes process_tags
and container_id. Reverts build.yml back to @main.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tlhunter tlhunter marked this pull request as ready for review March 18, 2026 22:50
@tlhunter tlhunter merged commit 45cefe4 into main Mar 19, 2026
161 of 181 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants