Update build action to use latest prebuildify#106
Closed
Conversation
Member
Author
|
This PR didn't fix anything:
Perhaps this is needed first DataDog/action-prebuildify#102 |
2 tasks
References the pin update branch (fe48fca) which includes the v3 naming fix so that Rust prebuild binaries retain their crate names instead of all being named node-napi.node. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
szegedi
previously approved these changes
Mar 23, 2026
szegedi
added a commit
to DataDog/action-prebuildify
that referenced
this pull request
Mar 23, 2026
The RUST=true code path scans all files from build/Release/ and
applies prebuildFilename() to generate output names. This works for
.node libraries but incorrectly renames plain binaries (e.g.
crashtracker-receiver) by adding a -napi.node suffix.
The old pre-PR#90 code used .replace('.node', '-napi.node') which was
a no-op for files without .node in their name, preserving binaries
as-is. The refactored code unconditionally applied the naming
convention.
Fix: only apply prebuildFilename() to .node files; copy other files
with their original name.
Fixes crashtracker test failures in DataDog/libdatadog-nodejs#106.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
Overall package sizeSelf size: 36.05 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
szegedi
added a commit
to DataDog/action-prebuildify
that referenced
this pull request
Mar 23, 2026
The RUST=true code path scans all files from build/Release/ and
applies prebuildFilename() to generate output names. This works for
.node libraries but incorrectly renames plain binaries (e.g.
crashtracker-receiver) by adding a -napi.node suffix.
The old pre-PR#90 code used .replace('.node', '-napi.node') which was
a no-op for files without .node in their name, preserving binaries
as-is. The refactored code unconditionally applied the naming
convention.
Fix: only apply prebuildFilename() to .node files; copy other files
with their original name.
Fixes crashtracker test failures in DataDog/libdatadog-nodejs#106.
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tlhunter
force-pushed
the
tlhunter/prebuildify-main
branch
from
7268eba to
a97d5c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverts changes in a0ac460 / #104
depends on DataDog/action-prebuildify#100 ✅
depends on DataDog/action-prebuildify#101 ✅