Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fecc6f1307
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
18b2b9e to
06d9e93
Compare
Overall package sizeSelf size: 31.41 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Also consistently upgrades to v40.0.0 instead of multiple revs being pinned.
| // Node itself exposes one major later. An existing one is never overwritten. | ||
| module.exports.ensureWebCrypto = function ensureWebCrypto () { | ||
| if (globalThis.crypto === undefined) { | ||
| globalThis.crypto = require('node:crypto').webcrypto |
There was a problem hiding this comment.
Do we do this in other places? We should avoid modifying the global if we can.
There was a problem hiding this comment.
Well, the generated wasm directly defers to crypto...
It's just a polyfill for node 18 and 19.
There was a problem hiding this comment.
"Just" a polyfill that may impact or be impacted by customer code. Can we make the generated wasm code not do this?
* Add remote config wasm layer Also consistently upgrades to v40.0.0 instead of multiple revs being pinned. * Address codex comments * Fix node v18 test * Update to agentless rc * Drop webcrypto polyfill
* Add remote config wasm layer Also consistently upgrades to v40.0.0 instead of multiple revs being pinned. * Address codex comments * Fix node v18 test * Update to agentless rc * Drop webcrypto polyfill
2 participants
Also consistently upgrades everything to the same rev instead of multiple revs being pinned.
Tests in particular completely LLM generated.