Build using libdatadog's builder crate#33
Merged
Merged
Conversation
Merged
Strech
approved these changes
May 6, 2026
Member
Strech
left a comment
Strech
left a comment
There was a problem hiding this comment.
LGTM, but I would ask other Ruby peers for a round 👍🏼
Member
|
Note: It would really nice to get a review from @hoolioh before this gets merged ;) |
hoolioh
reviewed
May 6, 2026
hoolioh
approved these changes
May 6, 2026
hoolioh
left a comment
hoolioh
left a comment
There was a problem hiding this comment.
Aside from removing the unneded env vars it's a sounding step to have the builder integrated in the project.
Member
Author
|
Let's merge this and remove in a subsequent PR: #39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Best of #18 and #24 together
What does this PR do?
Build with
libdatadog'sbuildercrateHow to test the change?
Additional Notes:
Next-in-chain PR: #34
JIRA: