Skip to content

chore(crashtracking): add checks for receiver timeout - #2178

Merged
gyuheon0h merged 1 commit into
mainfrom
gyuheon0h/PROF-15207-timeout-harden
Jul 1, 2026
Merged

chore(crashtracking): add checks for receiver timeout#2178
gyuheon0h merged 1 commit into
mainfrom
gyuheon0h/PROF-15207-timeout-harden

Conversation

@gyuheon0h

@gyuheon0h gyuheon0h commented Jun 29, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

PROF-15207

What does this PR do?

This PR adds an explicit bin test that checks that even when the receiver times out in the middle of receiving stack trace frames, it still correctly generates a crash report marked as incomplete

Motivation

We have no testing for receiver timeouts in middle of report generation

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@gyuheon0h Graphite App

gyuheon0h commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/gyuheon0h/PROF-15207-timeout-harden

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 22 22 No change (0%)
datadog-live-debugger 4 4 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-sidecar 45 45 No change (0%)
libdd-common 13 13 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 6 6 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-remote-config 3 3 No change (0%)
libdd-telemetry 20 20 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 3 3 No change (0%)
libdd-trace-stats 1 1 No change (0%)
libdd-trace-utils 11 11 No change (0%)
Total 182 182 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📚 Documentation Check Results

⚠️ 1679 documentation warning(s) found

📦 bin_tests - 1679 warning(s)

Updated: 2026-06-29 21:51:28 UTC | Commit: c272526 | missing-docs job results

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 29, 2026 •
edited by datadog-prod-us1-6 Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 73.96% (-0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 863182e | Docs | Datadog PR Page | Give us feedback!

@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔒 Cargo Deny Results

⚠️ 7 issue(s) found, showing only errors (advisories, bans, sources)

📦 bin_tests - 7 error(s)

Show output 
error[unsound]: Unsoundness in `Error::downcast_mut()`
  ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:8:1
  │
8 │ anyhow 1.0.93 registry+https://github.com/rust-lang/crates.io-index
  │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
  │
  ├ ID: RUSTSEC-2026-0190
  ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0190
  ├ Affected versions of this crate violate borrow rules, resulting in undefined behavior, when the user adds context to an error via `Error::context` and then later calls `Error::downcast_mut` on the returned `Error`.
    
    The flaw was corrected in commit `6e8c000` by revising how the mutable reference is constructed, avoiding inclusion of a shared reference in the resulting borrow chain.
    
    ## Example
    
    ```rust
    use anyhow::Error;
    use std::fmt;
    
    #[derive(Debug)]
    struct ErrorContext(&'static str);
    
    impl fmt::Display for ErrorContext {
        fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
            fmt::Display::fmt(&self.0, f)
        }
    }
    
    fn main() {
        let mut error = Error::msg("inner error").context(ErrorContext("old context"));
        let context: &mut ErrorContext = error.downcast_mut().unwrap();
        context.0 = "new context";
        println!("{:?}", error);
    }
    ```
    
    ## Miri output
    
    ```
    error: Undefined Behavior: trying to retag from <1538> for Unique permission at alloc602[0x38], but that tag only grants SharedReadOnly permission for this location
       --> src/ptr.rs:170:18
        |
    170 |         unsafe { &mut *self.ptr.as_ptr() }
        |                  ^^^^^^^^^^^^^^^^^^^^^^^ this error occurs as part of retag at alloc602[0x38..0x48]
        |
        = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental
        = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
    help: <1538> was created by a SharedReadOnly retag at offsets [0x38..0x48]
       --> src/ptr.rs:89:18
        |
     89 |             ptr: NonNull::from(ptr),
        |                  ^^^^^^^^^^^^^^^^^^
        = note: stack backtrace:
                0: anyhow::ptr::Mut::<'_, ErrorContext>::deref_mut
                    at src/ptr.rs:170:18: 170:41
                1: anyhow::error::<impl anyhow::Error>::downcast_mut::<ErrorContext>
                    at src/error.rs:560:18: 560:46
                2: main
                    at examples/downcast_mut.rs:15:38: 15:58
    ```
  ├ Announcement: https://github.com/dtolnay/anyhow/issues/451
  ├ Solution: Upgrade to >=1.0.103 (try `cargo update -p anyhow`)
  ├ anyhow v1.0.93
    ├── bin_tests v0.1.0
    ├── bolero-engine v0.13.4
    │   ├── bolero v0.13.4
    │   │   ├── (dev) libdd-alloc v1.0.0
    │   │   │   └── libdd-profiling v1.0.0
    │   │   │       ├── bin_tests v0.1.0 (*)
    │   │   │       └── (dev) libdd-profiling v1.0.0 (*)
    │   │   ├── (dev) libdd-profiling v1.0.0 (*)
    │   │   └── libdd-profiling-protobuf v2.0.0
    │   │       ├── libdd-profiling v1.0.0 (*)
    │   │       └── (dev) libdd-profiling-protobuf v2.0.0 (*)
    │   ├── bolero-afl v0.13.0
    │   │   └── bolero v0.13.4 (*)
    │   ├── bolero-honggfuzz v0.13.0
    │   │   └── bolero v0.13.4 (*)
    │   ├── bolero-kani v0.13.0
    │   │   └── bolero v0.13.4 (*)
    │   └── bolero-libfuzzer v0.13.0
    │       └── bolero v0.13.4 (*)
    ├── libdd-capabilities v2.0.0
    │   ├── libdd-capabilities-impl v2.0.0
    │   │   └── libdd-shared-runtime v1.0.0
    │   │       └── libdd-telemetry v5.0.1
    │   │           └── libdd-crashtracker v1.0.0
    │   │               └── bin_tests v0.1.0 (*)
    │   └── libdd-shared-runtime v1.0.0 (*)
    ├── libdd-common v5.0.0
    │   ├── bin_tests v0.1.0 (*)
    │   ├── libdd-capabilities-impl v2.0.0 (*)
    │   ├── (build) libdd-crashtracker v1.0.0 (*)
    │   ├── libdd-profiling v1.0.0 (*)
    │   ├── libdd-shared-runtime v1.0.0 (*)
    │   └── libdd-telemetry v5.0.1 (*)
    ├── libdd-crashtracker v1.0.0 (*)
    ├── libdd-profiling v1.0.0 (*)
    ├── libdd-telemetry v5.0.1 (*)
    └── prost-derive v0.14.3
        └── prost v0.14.3
            ├── libdd-ddsketch v1.0.1
            │   └── libdd-telemetry v5.0.1 (*)
            ├── libdd-profiling v1.0.0 (*)
            └── libdd-profiling-protobuf v2.0.0 (*)

error[vulnerability]: NSEC3 closest-encloser proof validation enters unbounded loop on cross-zone responses
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:124:1
    │
124 │ hickory-proto 0.25.2 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0118
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0118
    ├ The NSEC3 closest-encloser proof validation in `hickory-proto`'s
      `DnssecDnsHandle` walks from the QNAME up to the SOA owner name, building a
      list of candidate encloser names. The iterator used assumes the
      QNAME is a descendant of the SOA owner, terminating only when the current
      candidate equals the SOA name. When the SOA in a response's authority section
      is not an ancestor of the QNAME, the loop stalls at the DNS root and never
      terminates, repeatedly calling `Name::base_name()` and pushing newly allocated
      `Name` and hashed-name entries into the candidate `Vec`.
      
      The bug is reachable by any caller of `DnssecDnsHandle` — including the
      resolver, recursor, and client — when built with the `dnssec-ring` or
      `dnssec-aws-lc-rs` feature and configured to perform DNSSEC validation. It is
      triggered while validating a NoData or NXDomain response whose authority
      section contains an SOA record from a zone other than an ancestor of the
      QNAME, on a code path that requires NSEC3 closest-encloser proof. In practice
      this can be reached through an insecure CNAME chain that crosses zone
      boundaries into a DNSSEC-signed zone returning NoData, but the minimum
      condition is just a mismatched SOA owner on a response requiring NSEC3
      validation.
      
      A `debug_assert_ne!(name, Name::root())` guards the loop body, so debug builds
      abort with a panic on the first iteration past the root. Release builds
      compile the assertion out and run the loop unbounded, allocating until the
      process exhausts available memory (OOM). A reachable upstream attacker who
      can return such a response can therefore crash a debug-built validator or
      exhaust memory on a release-built one.
      
      The affected code was migrated from `hickory-proto` to `hickory-net` as part of
      the 0.26.0 release. The `hickory-proto` 0.26.x release no longer offers
      `DnssecDnsHandle` and so we recommend all affected users update to `hickory-net`
      0.26.1 when the implementation of that type is required.
    ├ Announcement: https://github.com/hickory-dns/hickory-dns/security/advisories/GHSA-3v94-mw7p-v465
    ├ Solution: No safe upgrade is available!
    ├ hickory-proto v0.25.2
      └── hickory-resolver v0.25.2
          └── reqwest v0.13.2
              ├── libdd-common v5.0.0
              │   ├── bin_tests v0.1.0
              │   ├── libdd-capabilities-impl v2.0.0
              │   │   └── libdd-shared-runtime v1.0.0
              │   │       └── libdd-telemetry v5.0.1
              │   │           └── libdd-crashtracker v1.0.0
              │   │               └── bin_tests v0.1.0 (*)
              │   ├── (build) libdd-crashtracker v1.0.0 (*)
              │   ├── libdd-profiling v1.0.0
              │   │   ├── bin_tests v0.1.0 (*)
              │   │   └── (dev) libdd-profiling v1.0.0 (*)
              │   ├── libdd-shared-runtime v1.0.0 (*)
              │   └── libdd-telemetry v5.0.1 (*)
              └── libdd-profiling v1.0.0 (*)

error[vulnerability]: CPU exhaustion during message encoding due to O(n²) name compression
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:124:1
    │
124 │ hickory-proto 0.25.2 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0119
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0119
    ├ During message encoding, `hickory-proto`'s `BinEncoder` stores pointers to
      labels that are candidates for name compression in a `Vec<(usize, Vec<u8>)>`.
      The name compression logic then searches for matches with a linear scan.
      
      A malicious message with many records can both introduce many candidate labels,
      and invoke this linear scan many times. This can amplify CPU exhaustion in DoS
      attacks.
      
      This is similar to
      [CVE-2024-8508](https://www.nlnetlabs.nl/downloads/unbound/CVE-2024-8508.txt).
      
      We recommend all affected users update to `hickory-proto` 0.26.1 for the fix.
    ├ Announcement: https://github.com/hickory-dns/hickory-dns/security/advisories/GHSA-q2qq-hmj6-3wpp
    ├ Solution: Upgrade to >=0.26.1 (try `cargo update -p hickory-proto`)
    ├ hickory-proto v0.25.2
      └── hickory-resolver v0.25.2
          └── reqwest v0.13.2
              ├── libdd-common v5.0.0
              │   ├── bin_tests v0.1.0
              │   ├── libdd-capabilities-impl v2.0.0
              │   │   └── libdd-shared-runtime v1.0.0
              │   │       └── libdd-telemetry v5.0.1
              │   │           └── libdd-crashtracker v1.0.0
              │   │               └── bin_tests v0.1.0 (*)
              │   ├── (build) libdd-crashtracker v1.0.0 (*)
              │   ├── libdd-profiling v1.0.0
              │   │   ├── bin_tests v0.1.0 (*)
              │   │   └── (dev) libdd-profiling v1.0.0 (*)
              │   ├── libdd-shared-runtime v1.0.0 (*)
              │   └── libdd-telemetry v5.0.1 (*)
              └── libdd-profiling v1.0.0 (*)

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:241:1
    │
241 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by @lopopolo) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── (dev) libdd-common v5.0.0
      │   ├── bin_tests v0.1.0
      │   ├── libdd-capabilities-impl v2.0.0
      │   │   └── libdd-shared-runtime v1.0.0
      │   │       └── libdd-telemetry v5.0.1
      │   │           └── libdd-crashtracker v1.0.0
      │   │               └── bin_tests v0.1.0 (*)
      │   ├── (build) libdd-crashtracker v1.0.0 (*)
      │   ├── libdd-profiling v1.0.0
      │   │   ├── bin_tests v0.1.0 (*)
      │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   ├── libdd-shared-runtime v1.0.0 (*)
      │   └── libdd-telemetry v5.0.1 (*)
      ├── libdd-crashtracker v1.0.0 (*)
      ├── (dev) libdd-ddsketch v1.0.1
      │   └── libdd-telemetry v5.0.1 (*)
      ├── libdd-profiling v1.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-profiling v1.0.0 (*)

error[vulnerability]: Name constraints for URI names were incorrectly accepted
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:267:1
    │
267 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0098
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0098
    ├ Name constraints for URI names were ignored and therefore accepted.
      
      Note this library does not provide an API for asserting URI names, and URI name constraints are otherwise not implemented.  URI name constraints are now rejected unconditionally.
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-965h-392x-2mh5](https://github.com/rustls/webpki/security/advisories/GHSA-965h-392x-2mh5). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v5.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── libdd-capabilities-impl v2.0.0
      │   │   │   │   └── libdd-shared-runtime v1.0.0
      │   │   │   │       └── libdd-telemetry v5.0.1
      │   │   │   │           └── libdd-crashtracker v1.0.0
      │   │   │   │               └── bin_tests v0.1.0 (*)
      │   │   │   ├── (build) libdd-crashtracker v1.0.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v1.0.0 (*)
      │   │   │   └── libdd-telemetry v5.0.1 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v5.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v5.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-common v5.0.0 (*)
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v5.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

error[vulnerability]: Name constraints were accepted for certificates asserting a wildcard name
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:267:1
    │
267 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0099
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0099
    ├ Permitted subtree name constraints for DNS names were accepted for certificates asserting a wildcard name.
      
      This was incorrect because, given a name constraint of `accept.example.com`, `*.example.com` could feasibly allow a name of `reject.example.com` which is outside the constraint.
      This is very similar to [CVE-2025-61727](https://go.dev/issue/76442).
      
      Since name constraints are restrictions on otherwise properly-issued certificates, this bug is reachable only after signature verification and requires misissuance to exploit.
      
      This vulnerability is identified as [GHSA-xgp8-3hg3-c2mh](https://github.com/rustls/webpki/security/advisories/GHSA-xgp8-3hg3-c2mh). Thank you to @1seal for the report.
    ├ Solution: Upgrade to >=0.103.12, <0.104.0-alpha.1 OR >=0.104.0-alpha.6 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v5.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── libdd-capabilities-impl v2.0.0
      │   │   │   │   └── libdd-shared-runtime v1.0.0
      │   │   │   │       └── libdd-telemetry v5.0.1
      │   │   │   │           └── libdd-crashtracker v1.0.0
      │   │   │   │               └── bin_tests v0.1.0 (*)
      │   │   │   ├── (build) libdd-crashtracker v1.0.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v1.0.0 (*)
      │   │   │   └── libdd-telemetry v5.0.1 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v5.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v5.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-common v5.0.0 (*)
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v5.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

error[vulnerability]: Reachable panic in certificate revocation list parsing
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:267:1
    │
267 │ rustls-webpki 0.103.10 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2026-0104
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0104
    ├ A panic was reachable when parsing certificate revocation lists via [`BorrowedCertRevocationList::from_der`]
      or [`OwnedCertRevocationList::from_der`].  This was the result of mishandling a syntactically valid empty
      `BIT STRING` appearing in the `onlySomeReasons` element of a `IssuingDistributionPoint` CRL extension.
      
      This panic is reachable prior to a CRL's signature being verified.
      
      Applications that do not use CRLs are not affected.
      
      Thank you to @tynus3 for the report.
    ├ Solution: Upgrade to >=0.103.13, <0.104.0-alpha.1 OR >=0.104.0-alpha.7 (try `cargo update -p rustls-webpki`)
    ├ rustls-webpki v0.103.10
      ├── rustls v0.23.37
      │   ├── hyper-rustls v0.27.7
      │   │   ├── libdd-common v5.0.0
      │   │   │   ├── bin_tests v0.1.0
      │   │   │   ├── libdd-capabilities-impl v2.0.0
      │   │   │   │   └── libdd-shared-runtime v1.0.0
      │   │   │   │       └── libdd-telemetry v5.0.1
      │   │   │   │           └── libdd-crashtracker v1.0.0
      │   │   │   │               └── bin_tests v0.1.0 (*)
      │   │   │   ├── (build) libdd-crashtracker v1.0.0 (*)
      │   │   │   ├── libdd-profiling v1.0.0
      │   │   │   │   ├── bin_tests v0.1.0 (*)
      │   │   │   │   └── (dev) libdd-profiling v1.0.0 (*)
      │   │   │   ├── libdd-shared-runtime v1.0.0 (*)
      │   │   │   └── libdd-telemetry v5.0.1 (*)
      │   │   └── reqwest v0.13.2
      │   │       ├── libdd-common v5.0.0 (*)
      │   │       └── libdd-profiling v1.0.0 (*)
      │   ├── libdd-common v5.0.0 (*)
      │   ├── libdd-profiling v1.0.0 (*)
      │   ├── reqwest v0.13.2 (*)
      │   ├── rustls-platform-verifier v0.6.2
      │   │   ├── libdd-common v5.0.0 (*)
      │   │   ├── libdd-profiling v1.0.0 (*)
      │   │   └── reqwest v0.13.2 (*)
      │   └── tokio-rustls v0.26.0
      │       ├── hyper-rustls v0.27.7 (*)
      │       ├── libdd-common v5.0.0 (*)
      │       └── reqwest v0.13.2 (*)
      └── rustls-platform-verifier v0.6.2 (*)

advisories FAILED, bans ok, sources ok

Updated: 2026-06-29 21:52:53 UTC | Commit: c272526 | dependency-check job results

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-15207-timeout-harden branch from 1808318 to 80adc50 Compare June 29, 2026 17:38
@gyuheon0h gyuheon0h changed the title Add bin tests for graceful timeout chore(crashtracking): add checks for receiver timeout Jun 29, 2026
@gyuheon0h
gyuheon0h marked this pull request as ready for review June 29, 2026 17:43
@gyuheon0h
gyuheon0h requested a review from a team as a code owner June 29, 2026 17:43
@gyuheon0h
gyuheon0h requested a review from gleocadie June 29, 2026 17:43
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 29, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80adc501b8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread libdd-crashtracker/src/receiver/receive_report.rs Outdated
Comment thread bin_tests/tests/crashtracker_bin_test.rs Outdated
@gyuheon0h
gyuheon0h marked this pull request as draft June 29, 2026 17:52
@dd-octo-sts

dd-octo-sts Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 84.54 MB 84.54 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.76 MB 7.76 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.68 MB 95.68 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.43 MB 10.43 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.02 MB 25.02 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 87.33 KB 87.33 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 181.76 MB 181.76 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 932.38 MB 932.38 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.20 MB 8.20 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 87.33 KB 87.33 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.13 MB 24.13 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 48.20 MB 48.20 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.68 MB 21.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 88.71 KB 88.71 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 185.74 MB 185.75 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 920.87 MB 920.87 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.32 MB 6.32 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 88.71 KB 88.71 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 25.89 MB 25.89 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 45.82 MB 45.82 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 75.37 MB 75.37 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.68 MB 8.68 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 90.82 MB 90.82 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.55 MB 10.55 MB 0% (0 B) 👌

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-15207-timeout-harden branch from 80adc50 to bc733b9 Compare June 29, 2026 19:27
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-15207-timeout-harden branch from bc733b9 to 02869a2 Compare June 29, 2026 19:45
@gyuheon0h
gyuheon0h marked this pull request as ready for review June 29, 2026 20:06
@gyuheon0h gyuheon0h self-assigned this Jun 29, 2026
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 29, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02869a2487

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread bin_tests/tests/crashtracker_bin_test.rs
Comment thread bin_tests/tests/crashtracker_bin_test.rs
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-15207-timeout-harden branch from 02869a2 to 9d5acf9 Compare June 29, 2026 20:27
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/PROF-15207-timeout-harden branch from 9d5acf9 to 863182e Compare June 29, 2026 21:49
@gyuheon0h
gyuheon0h merged commit 41fb85e into main Jul 1, 2026
54 checks passed
@gyuheon0h
gyuheon0h deleted the gyuheon0h/PROF-15207-timeout-harden branch July 1, 2026 16:39
gleocadie
gleocadie reviewed Jul 2, 2026
View reviewed changes

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taegyunkim pushed a commit that referenced this pull request Jul 8, 2026
@gyuheon0h @taegyunkim
chore(crashtracking): add checks for receiver timeout (#2178)
a15470a 
[PROF-15207](https://datadoghq.atlassian.net/jira/software/c/projects/PROF/boards/11?selectedIssue=PROF-15207)
# What does this PR do?

This PR adds an explicit bin test that checks that even when the
receiver times out in the middle of receiving stack trace frames, it
still correctly generates a crash report marked as incomplete

# Motivation

We have no testing for receiver timeouts in middle of report generation

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?

Describe here in detail how the change can be validated.

[PROF-15207]:
https://datadoghq.atlassian.net/browse/PROF-15207?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Signed-off-by: Taegyun Kim <taegyun.kim@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gleocadie gleocadie gleocadie left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@taegyunkim taegyunkim taegyunkim approved these changes

Assignees

@gyuheon0h gyuheon0h

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gyuheon0h @taegyunkim @gleocadie