Skip to content

ci(fuzz): fix gitlab fuzz job that has started to fail on main due to pulling in packages above MSRV - #2185

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
ekump/APMSP-3618-fix-failing-fuzz-ci-job
Jul 1, 2026
Merged

ci(fuzz): fix gitlab fuzz job that has started to fail on main due to pulling in packages above MSRV#2185
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
ekump/APMSP-3618-fix-failing-fuzz-ci-job

Conversation

@ekump

@ekump ekump commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

The fuzz job on gitlab has started to fail on main.

The job does rustup default nightly-2026-02-08 (rustc 1.95) at line 26, but cargo install then runs inside the repo directory, where rust-toolchain.toml pins channel = "1.87.0". A rust-toolchain.toml directory override beats the rustup default, so cargo-fuzz gets compiled with 1.87.0.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Ran the fuzz job manually on my PR

@ekump
ekump requested a review from a team as a code owner July 1, 2026 12:54
@datadog-datadog-prod-us1-2

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 74.34% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9b16b84 | Docs | Datadog PR Page | Give us feedback!

@ekump

ekump commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 1, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-01 13:17:17 UTC ℹ️ Start processing command /merge


2026-07-01 13:17:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-01 13:56:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-07-01 15:02:11 UTC ℹ️ MergeQueue: This merge request was merged

@dd-octo-sts

dd-octo-sts Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 85.64 MB 85.64 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.88 MB 7.88 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.60 MB 10.60 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 96.81 MB 96.81 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.41 MB 25.41 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 88.04 KB 88.04 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.51 MB 184.50 MB -0% (-16.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 945.48 MB 945.48 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.29 MB 8.29 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 88.04 KB 88.04 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.52 MB 24.52 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 48.85 MB 48.85 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.02 MB 22.02 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 89.42 KB 89.42 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.52 MB 188.52 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 932.67 MB 932.67 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.41 MB 6.41 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 89.42 KB 89.42 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.32 MB 26.32 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 46.48 MB 46.48 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 76.38 MB 76.38 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.76 MB 8.76 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.86 MB 91.86 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.66 MB 10.66 MB 0% (0 B) 👌

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 68f664b into main Jul 1, 2026
104 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the ekump/APMSP-3618-fix-failing-fuzz-ci-job branch July 1, 2026 15:02
taegyunkim pushed a commit that referenced this pull request Jul 8, 2026
… pulling in packages above MSRV (#2185)

# What does this PR do?
The fuzz job on gitlab has started to [fail on main](https://gitlab.ddbuild.io/DataDog/apm-reliability/libdatadog/-/jobs/1820649675
).

The job does rustup default nightly-2026-02-08 (rustc 1.95) at line 26, but cargo install then runs inside the repo directory, where rust-toolchain.toml pins channel = "1.87.0". A rust-toolchain.toml directory override beats the rustup default, so      cargo-fuzz gets compiled with 1.87.0.

# Motivation

What inspired you to submit this pull request?

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?

[Ran the fuzz job manually on my PR](https://gitlab.ddbuild.io/DataDog/apm-reliability/libdatadog/-/jobs/1820747534)

Co-authored-by: edmund.kump <edmund.kump@datadoghq.com>
Signed-off-by: Taegyun Kim <taegyun.kim@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants