Skip to content

refactor(rc)!: make conversion from RemoteConfigProduct back and forth generally available - #2325

Merged
morrisonlevi merged 3 commits into
mainfrom
bob/strum-rc-enum
Aug 7, 2026
Merged

refactor(rc)!: make conversion from RemoteConfigProduct back and forth generally available#2325
morrisonlevi merged 3 commits into
mainfrom
bob/strum-rc-enum

Conversation

@bwoebi

@bwoebi bwoebi commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

In wasm we need to shuffle these around via string repr, hence simply use strum to expose this.

Renaming the enum values to be more canonical.

@bwoebi
bwoebi requested review from a team as code owners August 6, 2026 14:34
@bwoebi bwoebi changed the title Make conversion from RemoteConfigProduct back and forth generally available refactor(rc): make conversion from RemoteConfigProduct back and forth generally available Aug 6, 2026

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Autotest was unable to complete this review. View session

Please try again by commenting @autotest review.

@bwoebi

bwoebi commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 6, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-06 14:40:31 UTC ℹ️ Start processing command /merge


2026-08-06 14:40:38 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-08-06 15:14:27 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 50m (p90).


2026-08-06 16:01:09 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit 69f7a74:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@bwoebi bwoebi changed the title refactor(rc): make conversion from RemoteConfigProduct back and forth generally available refactor(rc)!: make conversion from RemoteConfigProduct back and forth generally available Aug 6, 2026
@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Aug 6, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 80.00%
Overall Coverage: 75.82%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 08be668 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 6, 2026

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-08-07 04:29:59

Comparing candidate commit 08be668 in PR branch bob/strum-rc-enum with baseline commit 05d785e in branch main.

Found 9 performance improvements and 1 performance regressions! Performance is the same for 130 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:tags/replace_trace_tags

  • 🟥 execution_time [+104.831ns; +118.240ns] or [+4.434%; +5.001%]

scenario:vec_map/as_deduped_map/needs_dedup_1_in_4/8

  • 🟩 execution_time [-18.680ns; -18.481ns] or [-4.550%; -4.501%]

scenario:vec_map/insert/128

  • 🟩 execution_time [-1.134µs; -1.126µs] or [-31.005%; -30.785%]
  • 🟩 throughput [+15577139.237op/s; +15718084.215op/s] or [+44.517%; +44.920%]

scenario:vec_map/insert/16

  • 🟩 execution_time [-143.795ns; -141.127ns] or [-24.881%; -24.420%]
  • 🟩 throughput [+8971641.350op/s; +9150746.654op/s] or [+32.401%; +33.048%]

scenario:vec_map/insert/64

  • 🟩 execution_time [-564.289ns; -560.214ns] or [-29.844%; -29.629%]
  • 🟩 throughput [+14265293.247op/s; +14390627.336op/s] or [+42.144%; +42.514%]

scenario:vec_map/insert/8

  • 🟩 execution_time [-73.689ns; -72.914ns] or [-25.014%; -24.751%]
  • 🟩 throughput [+8950186.626op/s; +9040894.357op/s] or [+32.956%; +33.290%]

Benchmark execution time: 2026-08-07 04:28:38

Comparing candidate commit 08be668 in PR branch bob/strum-rc-enum with baseline commit 05d785e in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 88 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:datadog_sample_span/resource_pattern_rule_not_matching/wall_time

  • 🟥 execution_time [+12.359ns; +12.476ns] or [+7.755%; +7.828%]

Candidate

Omitted due to size.

Baseline

Omitted due to size.

@dd-octo-sts

dd-octo-sts Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 89.19 MB 89.19 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.20 MB 8.20 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.06 MB 11.06 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.37 MB 100.37 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 26.63 MB 26.63 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 94.56 KB 94.56 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 191.42 MB 191.43 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 1001.53 MB 1001.58 MB +0% (+52.54 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.71 MB 8.71 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 94.56 KB 94.56 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 25.62 MB 25.62 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.01 MB 51.01 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.22 MB 23.22 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 96.04 KB 96.04 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 196.32 MB 196.33 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 990.59 MB 990.64 MB +0% (+51.86 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.73 MB 6.73 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 96.04 KB 96.04 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 27.55 MB 27.55 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 48.55 MB 48.55 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 79.47 MB 79.47 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.13 MB 9.13 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.12 MB 95.12 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.14 MB 11.14 MB 0% (0 B) 👌

@bwoebi

bwoebi commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 6, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-06 16:01:57 UTC ℹ️ Start processing command /merge


2026-08-06 16:02:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 50m (p90).


2026-08-06 16:46:54 UTC ⚠️ MergeQueue: This merge request build was cancelled

bob.weinand@datadoghq.com cancelled this merge request build

@bwoebi

bwoebi commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

/merge -c

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 6, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-06 16:46:44 UTC ℹ️ Start processing command /merge -c

…ilable

In wasm we need to shuffle these around via string repr, hence simply use strum to expose this.

Renaming the enum values to be more canonical.
@bwoebi
bwoebi force-pushed the bob/strum-rc-enum branch from 345c611 to 9f088a4 Compare August 7, 2026 03:03
@bwoebi

bwoebi commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-07 03:03:33 UTC ℹ️ Start processing command /merge


2026-08-07 03:03:39 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-08-07 03:58:31 UTC ⚠️ MergeQueue: This merge request was unqueued

levi.morrison@datadoghq.com unqueued this merge request

@morrisonlevi
morrisonlevi requested review from a team as code owners August 7, 2026 03:56
@morrisonlevi
morrisonlevi requested review from btthomas and typotter and removed request for a team August 7, 2026 03:56
@morrisonlevi

Copy link
Copy Markdown
Contributor

/merge -c

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 7, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-07 03:58:24 UTC ℹ️ Start processing command /merge -c

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The refactor preserves the established uppercase remote-config product tokens for display and path parsing, including ASM_DD, LIVE_DEBUGGING, and LIVE_DEBUGGING_SYMBOL_DB, and all in-repository enum call sites were migrated. Focused Rust execution could not complete because the sandbox cannot fetch the workspace's pinned proptest git dependency.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 08be668 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@morrisonlevi
morrisonlevi merged commit ea75b04 into main Aug 7, 2026
82 of 83 checks passed
@morrisonlevi
morrisonlevi deleted the bob/strum-rc-enum branch August 7, 2026 05:06
hoolioh added a commit that referenced this pull request Aug 7, 2026
…er-flare (#2332)

# Release proposal for libdd-ffe, libdd-http-client, libdd-tracer-flare
and their dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-capabilities
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-v3.0.0`

### Commits

- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- feat(capabilities)!: Add streaming to http capabilities (#2251)
- feat: added file capability [APMSP-3780] (#2240)
- feat: added environment capability [APMSP-3780] (#2239)

## libdd-common
**Next version:** `5.1.1`
**Semver bump:** `patch`
**Tag:** `libdd-common-v5.1.1`

### Commits

- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- test: stabilize flaky tests (#2256)
- fix(sidecar): don't double-encode file:// telemetry endpoints (#2230)
- fix: last new clippy lint (#2221)

## libdd-tinybytes
**Next version:** `1.1.2`
**Semver bump:** `patch`
**Tag:** `libdd-tinybytes-v1.1.2`

### Commits

- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)

## libdd-trace-protobuf
**Next version:** `4.0.1`
**Semver bump:** `patch`
**Tag:** `libdd-trace-protobuf-v4.0.1`

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)

## libdd-capabilities-impl
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-impl-v4.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0

### Commits

- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- feat(capabilities)!: Add streaming to http capabilities (#2251)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat: added file capability [APMSP-3780] (#2240)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- feat: added environment capability [APMSP-3780] (#2239)

## libdd-http-client
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-http-client-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-trace-normalization
**Next version:** `3.0.1`
**Semver bump:** `patch`
**Tag:** `libdd-trace-normalization-v3.0.1`

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)

## libdd-remote-config
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-remote-config-v3.0.0`

### Commits

- refactor(rc)!: make conversion from RemoteConfigProduct back and forth
generally available (#2325)
- fix(wasm)!: finish the WASM port of remote-config (#2315)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- feat(rc): Handle expired config status (#2274)
- feat(remote-config)!: add AsmRawResponseBody capability (#2278)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- fix(rc): Make Target fields available again after eaf5ad0 (#2232)
- fix: new clippy lints (#2219)

## libdd-trace-utils
**Next version:** `10.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-utils-v10.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0

### Commits

- refactor(rc)!: make conversion from RemoteConfigProduct back and forth
generally available (#2325)
- fix(libdd-trace-utils): apply SpanLink flags masking when v0.5 json
encoding (#2314)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- feat(data-pipeline)!: add compression option for agentless export
(#2205)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- refactor(trace-utils)!: split generic TracerHeaderTags (#2279)
- chore(lint): update nightly (#2281)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)
- feat(trace-utils)!: add v1 decoder (#2174)
- feat(trace-utils)!: add encoder v1 to v04 + refactor (#2145)
- feat(otlp): add instrumentation scope metadata (#2235)
- fix(trace-utils)!: serialize v0.5 span links and events into meta
(#980)

## libdd-ffe
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-ffe-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-tracer-flare
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-tracer-flare-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
bwoebi added a commit that referenced this pull request Aug 7, 2026
…mote_config/agentless_fetcher

* 'main' of github.com:DataDog/libdatadog:
  feat(data-pipeline)!: add flush_and_close to the trace buffer (#2313)
  refactor(rc)!: make conversion from RemoteConfigProduct back and forth generally available (#2325)
  chore: release v40.0.0 (#2326)
  feat(datadog-ffe): server-side EVP flagevaluation payload + bincode-safe sidecar delivery (#2117)
  feat(data-pipeline): set structured span values (#2300)
  feat(telemetry)!: Add Installation signature and AppProduct changes payloads (#2213)
  fix(libdd-trace-utils): apply SpanLink flags masking when v0.5 json encoding (#2314)
  feat(data-pipeline): encode structured values (#2304)
  feat(crashtracking): send debug log when no data is received at all (#2321)
  chore: release v39.0.0 (#2324)
  feat(data-pipeline): add span links FFI (#2305)
  fix(crashtracking): check fields and exclude uuid for `has_data` (#2322)
  feat(data-pipeline): add span events FFI (#2301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants