Skip to content

feat: remove ffi-bake jobs - #2351

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
jwiriath/APMSP-3800-remove-ffi-bake
Aug 17, 2026
Merged

feat: remove ffi-bake jobs#2351
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
jwiriath/APMSP-3800-remove-ffi-bake

Conversation

@Aaalibaba42

@Aaalibaba42 Aaalibaba42 commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Remove the ffi-bake jobs.

Motivation

Don't waste time and ressources on useless pipelines:

  • They were not consumed
  • What they tested is tested already in gitlab with native gitlab runners
  • Thus they were not useful

Additional Notes

/

How to test the change?

See that they don't run anymore

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 13, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 76.47% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 701e1e2 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.20 MB 8.20 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 89.46 MB 89.46 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.06 MB 11.06 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.64 MB 100.64 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 26.62 MB 26.62 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 94.56 KB 94.56 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 180.63 MB 180.62 MB -0% (-16.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 771.67 MB 771.67 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.72 MB 8.72 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 94.56 KB 94.56 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 25.64 MB 25.64 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.06 MB 51.06 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.20 MB 23.20 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 96.04 KB 96.04 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 185.60 MB 185.61 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 759.92 MB 759.92 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.74 MB 6.74 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 96.04 KB 96.04 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 27.58 MB 27.58 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 48.61 MB 48.61 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 79.72 MB 79.72 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.15 MB 9.15 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.38 MB 95.38 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.16 MB 11.16 MB 0% (0 B) 👌

@Aaalibaba42
Aaalibaba42 marked this pull request as ready for review August 13, 2026 12:07
@Aaalibaba42
Aaalibaba42 requested a review from a team as a code owner August 13, 2026 12:07
@pr-commenter

pr-commenter Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Comparison

Candidate

Candidate benchmark details

Baseline

Baseline benchmark details

ekump
ekump approved these changes Aug 13, 2026
View reviewed changes

@ekump ekump left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description with the rationale behind removing this and give the rest of the guild a heads up before merging.

@Aaalibaba42
Aaalibaba42 force-pushed the jwiriath/APMSP-3800-remove-ffi-bake branch from 1dfe37a to 5c22a2d Compare August 14, 2026 09:26
morrisonlevi
morrisonlevi reviewed Aug 14, 2026
View reviewed changes

@morrisonlevi morrisonlevi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some Dockerfile that should be removed now too. Please verify.

Thanks for checking git history like I asked, posting here for completeness:

Apparently at some point in libddprof-build the alpine images did not build the ffi properly #65: Alpine builds are not able to generate ffi images properly and this PR is a first step to fix that problem, and I'm pretty sure nowadays it does, it's been redundant at least for a while

@Aaalibaba42
Aaalibaba42 force-pushed the jwiriath/APMSP-3800-remove-ffi-bake branch from e9f8287 to 79d5e94 Compare August 17, 2026 09:41
@Aaalibaba42

Aaalibaba42 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-08-17 09:42:12 UTC ℹ️ Start processing command /merge

2026-08-17 09:42:19 UTC ℹ️ MergeQueue: Pull request is not mergeable yet

It will be processed automatically as soon as GitHub reports it as mergeable. View in MergeQueue UI.

  • Run /code blockers to see what is blocking it.
  • Run /remove to cancel it.

2026-08-17 10:18:25 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).

2026-08-17 11:02:17 UTC ℹ️ MergeQueue: This merge request was merged

@Aaalibaba42
Aaalibaba42 force-pushed the jwiriath/APMSP-3800-remove-ffi-bake branch from 79d5e94 to 701e1e2 Compare August 17, 2026 09:42
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 3cd2b36 into main Aug 17, 2026
98 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the jwiriath/APMSP-3800-remove-ffi-bake branch August 17, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrisonlevi morrisonlevi morrisonlevi left review comments
@bantonsson bantonsson bantonsson approved these changes
@ekump ekump ekump approved these changes
@hoolioh hoolioh hoolioh approved these changes

Assignees

No one assigned

Labels

ci-build mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Aaalibaba42 @morrisonlevi @bantonsson @ekump @hoolioh