ci(release): hint at crates left out of a proposal affected by its major bumps - #2391
Merged
iunanua merged 2 commits intoAug 31, 2026
Conversation
…jor bumps Release candidates only come from publication-order.sh, which walks downward: the selected crates plus the libdd-* crates they depend on. Dependents outside that closure are never candidates, yet `cargo release version` still rewrites their dependency requirement to the new major. Their published version keeps requiring the old major, and their next proposal is force-bumped to major by major-bumps-level.sh with nothing having said so at the time. Report those crates, grouped by the major-bumped dependency, in the job log, the step summary and the proposal PR body. A crate is reported when it has a direct (non-dev, non-build) dependency on a crate released here at level major whose requirement now names the new major, which is the same extraction rule major-bumps-level.sh applies, so a hint cannot disagree with the audit that runs next time. The step is informational: it never touches the tree, always exits 0, and carries continue-on-error so a bug in the hints cannot fail a run whose version bumps are already committed. When nothing is affected the markdown file is empty and the PR body is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
hoolioh
approved these changes
Aug 31, 2026
Co-authored-by: Julio Gonzalez <107922352+hoolioh@users.noreply.github.com>
iunanua
marked this pull request as ready for review
August 31, 2026 10:09
iunanua
merged commit Aug 31, 2026
f63cac1
into
igor/versioning/proposal-wf-cleanup
21 of 23 checks passed
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4ec5224d9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [ | ||
| "### :warning: Crates left out of this proposal affected by its major bumps", | ||
| "", | ||
| "These publishable workspace crates are not part of this release but their dependency requirement was rewritten on this branch while their published version still requires the old major. If they're a dependency on your deployment not including them in the release could result in duplicate packages or symbol incompatibility.", |
There was a problem hiding this comment.
The apostrophe in they're terminates the single-quoted jq argument opened on line 72, so Bash reports a syntax error near def first_num(s) on every invocation. Because the workflow marks this step continue-on-error, release proposals still proceed but never produce the intended warning or markdown artifact; reword the contraction or escape it without ending the jq program.
Useful? React with 👍 / 👎.
iunanua
added a commit
that referenced
this pull request
Sep 2, 2026
…jor bumps (#2391) Release candidates only come from publication-order.sh, which walks downward: the selected crates plus the libdd-* crates they depend on. Dependents outside that closure are never candidates, yet `cargo release version` still rewrites their dependency requirement to the new major. Their published version keeps requiring the old major, and their next proposal is force-bumped to major by major-bumps-level.sh with nothing having said so at the time. Report those crates, grouped by the major-bumped dependency, in the job log, the step summary and the proposal PR body. A crate is reported when it has a direct (non-dev, non-build) dependency on a crate released here at level major whose requirement now names the new major, which is the same extraction rule major-bumps-level.sh applies, so a hint cannot disagree with the audit that runs next time. The step is informational. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Julio Gonzalez <107922352+hoolioh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Release candidates only come from publication-order.sh, which walks downward: the selected crates plus the libdd-* crates they depend on. Dependents outside that closure are never candidates, yet
cargo release versionstill rewrites their dependency requirement to the new major. Their published version keeps requiring the old major, and their next proposal is force-bumped to major by major-bumps-level.sh with nothing having said so at the time.Report those crates, grouped by the major-bumped dependency, in the job log, the step summary and the proposal PR body. A crate is reported when it has a direct (non-dev, non-build) dependency on a crate released here at level major whose requirement now names the new major, which is the same extraction rule major-bumps-level.sh applies, so a hint cannot disagree with the audit that runs next time.
The step is informational.