Skip to content

fix(crashtracking): async signal safety for sigchld bin tests - #2406

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
gyuheon0h/sigchld-bin-test-async-sgnl-safety
Aug 24, 2026
Merged

fix(crashtracking): async signal safety for sigchld bin tests#2406
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
gyuheon0h/sigchld-bin-test-async-sgnl-safety

Conversation

@gyuheon0h

@gyuheon0h gyuheon0h commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Use only async signal safe operations in SIGCHLD bin test

Motivation

While working on fix(crashtracking): introduce polling timeout for sigchld bin test, I noticed test getting killed by signal 9. I suspected async signal unsafe operations when we alloc strings, so I asked Claude to come up with a reproducer given my hypothesis. The reproducer is in this commit.

Without the fix, the reproducer hits, but with the fix, the failure is no longer reproducible.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

gyuheon0h commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@gyuheon0h gyuheon0h changed the title Reproducer fix(crashtracking): async signal safety for sigchld bin tests Aug 24, 2026
@gyuheon0h
gyuheon0h marked this pull request as ready for review August 24, 2026 18:25
@gyuheon0h
gyuheon0h requested a review from a team as a code owner August 24, 2026 18:25
@pr-commenter

pr-commenter Bot commented Aug 24, 2026

Copy link
Copy Markdown

Benchmarks

Comparison

Candidate

Candidate benchmark details

Baseline

Baseline benchmark details

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/sigchld-bin-test-async-sgnl-safety branch from 20c86cb to 154f94e Compare August 24, 2026 18:31
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 24, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 76.62% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 67329b2 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.26 MB 8.26 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 89.52 MB 89.52 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.06 MB 11.06 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 100.70 MB 100.70 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 26.64 MB 26.64 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 94.96 KB 94.96 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 180.73 MB 180.73 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 772.85 MB 772.85 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.73 MB 8.73 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 94.96 KB 94.96 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 25.65 MB 25.65 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.09 MB 51.09 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.22 MB 23.22 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 96.45 KB 96.45 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 185.66 MB 185.66 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 759.09 MB 759.09 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.74 MB 6.74 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 96.45 KB 96.45 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 27.59 MB 27.59 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 48.62 MB 48.62 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 79.78 MB 79.78 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.16 MB 9.16 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.42 MB 95.42 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.17 MB 11.17 MB 0% (0 B) 👌

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/sigchld-bin-test-async-sgnl-safety branch 2 times, most recently from f3adee7 to 79c0e7e Compare August 24, 2026 19:34
Base automatically changed from gyuheon0h/sigchld-file-content-wait to main August 24, 2026 20:05
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/sigchld-bin-test-async-sgnl-safety branch from 79c0e7e to 67329b2 Compare August 24, 2026 20:08
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 3de1c4c into main Aug 24, 2026
90 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the gyuheon0h/sigchld-bin-test-async-sgnl-safety branch August 24, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants