fix(crashtracking): async signal safety for sigchld bin tests - #2406
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intoAug 24, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gyuheon0h
marked this pull request as ready for review
August 24, 2026 18:25
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
gyuheon0h
force-pushed
the
gyuheon0h/sigchld-bin-test-async-sgnl-safety
branch
from
August 24, 2026 18:31
20c86cb to
154f94e
Compare
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 67329b2 | Docs | View more details | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
gyuheon0h
force-pushed
the
gyuheon0h/sigchld-bin-test-async-sgnl-safety
branch
2 times, most recently
from
August 24, 2026 19:34
f3adee7 to
79c0e7e
Compare
gyuheon0h
force-pushed
the
gyuheon0h/sigchld-bin-test-async-sgnl-safety
branch
from
August 24, 2026 20:08
79c0e7e to
67329b2
Compare
ekump
approved these changes
Aug 24, 2026
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
gyuheon0h/sigchld-bin-test-async-sgnl-safety
branch
August 24, 2026 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Use only async signal safe operations in SIGCHLD bin test
Motivation
While working on fix(crashtracking): introduce polling timeout for sigchld bin test, I noticed test getting killed by signal 9. I suspected async signal unsafe operations when we alloc strings, so I asked Claude to come up with a reproducer given my hypothesis. The reproducer is in this commit.
Without the fix, the reproducer hits, but with the fix, the failure is no longer reproducible.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.