fix(client): set User-Agent header in raw HTTP helpers - #256
Merged
Conversation
All three raw HTTP helpers (raw_get, raw_patch, raw_post) were omitting the User-Agent header, causing ddsql (and any other commands using these helpers like acp and synthetics) to send reqwest's default user agent instead of pup's versioned agent string. - Add `useragent::get()` header to raw_get, raw_patch, raw_post Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The raw HTTP helpers (
raw_get,raw_patch,raw_post) inclient.rswere never setting theUser-Agentheader, causingddsqland any other commands using these helpers to send reqwest's default user agent instead of pup's versioned string (pup/<version> (rust; os ...; arch ...)).Changes
useragentinclient.rs(src/client.rs:223).header("User-Agent", useragent::get())toraw_get,raw_patch, andraw_post(src/client.rs:511, 548, 584)Testing
cargo fmt— no changescargo clippy -- -D warnings— cleancargo check— cleanNotes
This also fixes the same missing header in
acp.rsandsynthetics.rswhich use the same raw helpers.🤖 Generated with Claude Code