refactor(util): extract parse_time_to_datetime helper - #402
Merged
Conversation
Replaces the repeated `from_timestamp_millis(...).unwrap()` pattern in command modules with a single helper in util.rs that returns a proper anyhow error on out-of-range timestamps. Eliminates a panic path on user-supplied time input. - Add util::parse_time_to_datetime with positive and negative tests - Update security, cicd, usage, cost, audit_logs, rum command modules Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chrono::DateTime::from_timestamp_millis(util::parse_time_to_unix_millis(&x)?).unwrap()pattern intoutil::parse_time_to_datetime..unwrap()panic paths on user-supplied time input across 6 command modules.Changes
parse_time_to_datetimeinsrc/util.rswith positive and negative testssecurity.rs,cicd.rs,usage.rs,cost.rs,audit_logs.rs,rum.rsTesting
cargo fmt --checkcargo clippy -- -D warningscargo test— new util tests + existing suite all pass🤖 Generated with Claude Code