feat(security): add --page-size and --page-number to rules list - #663
Merged
platinummonkey merged 3 commits intoJul 21, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
platinummonkey
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
--page-sizeand--page-numberflags topup security rules list, wiring them intoListSecurityMonitoringRulesOptionalParams.No JIRA ticket — standalone usability fix.
The implementation follows the existing pattern used by
pup users listand the internalbackend_rules_listfunction incsm_threats.rs, both of which already usepage_size/page_numberon the same SDK type.Will it impact other teams?
Only users of
pup security rules list— no cross-team service impact.Deploy plan
CLI binary only — no service deployments required.
Rollback plan
Revert the commit or pin to the previous
pupbinary version via Homebrew (brew switch pup <prev-version>).Testing Guidelines
--page-sizedefaults to 10 (matching the API's implicit default) and--page-numberto 0, so existing callers with no flags get identical behaviour.cargo checkpasses clean.🤖 Generated with Claude Code