traces metrics: send OAuth bearer token, request apm_generate_metrics by default | DAL-744 - #694
Merged
platinummonkey merged 2 commits intoJul 31, 2026
Conversation
… by default Flip from make_api_no_auth! to make_api! so the OAuth bearer is actually sent, and add apm_generate_metrics to default_scopes() alongside the existing apm_read, consistent with how other product write scopes (rum_generate_metrics, logs_generate_metrics) are already requested by default.
srosenthal-dd
marked this pull request as ready for review
July 29, 2026 05:19
srosenthal-dd
marked this pull request as draft
July 29, 2026 05:19
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c507e4c13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Addresses review feedback: cover ValidOAuthAccessToken on span-metrics requests, and assert apm_generate_metrics is default-scoped but excluded from read-only scopes.
srosenthal-dd
marked this pull request as ready for review
July 31, 2026 15:18
platinummonkey
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pup traces metrics {list,get,create,update,delete}frommake_api_no_auth!tomake_api!so the OAuth bearer is actually sent.apm_generate_metricstodefault_scopes().Scope check
apm_read(GET routes) is already indefault_scopes()-- no change needed.apm_generate_metrics(POST/PATCH/DELETE routes) was not indefault_scopes()orread_only_scopes(). Unlike scopes such asuser_access_manageorlogs_delete_data(deliberately excluded as broad/sensitive), this is a narrowly-scoped write permission comparable torum_generate_metrics/logs_generate_metrics, both already requested by default -- so this PR adds it todefault_scopes()rather than requiring--extra-scopes.Test plan
cargo test tracespassespup traces metrics listworks with OAuth login (default scopes)Jira: DAL-744