This repository was archived by the owner on Jun 13, 2023. It is now read-only.
Run over old systemd platform#49
Merged
JulienBalestra merged 10 commits intomasterfrom Jun 19, 2018
Merged
Conversation
JulienBalestra
force-pushed
the
JulienBalestra/ubuntu-1404
branch
6 times, most recently
from
e369aef to
3724787
Compare
logging: can use on legacy sd
JulienBalestra
force-pushed
the
JulienBalestra/ubuntu-1404
branch
from
3724787 to
105040e
Compare
JulienBalestra
force-pushed
the
JulienBalestra/ubuntu-1404
branch
7 times, most recently
from
61d03f6 to
ade740b
Compare
JulienBalestra
force-pushed
the
JulienBalestra/ubuntu-1404
branch
3 times, most recently
from
89036c1 to
ed3804a
Compare
JulienBalestra
force-pushed
the
JulienBalestra/ubuntu-1404
branch
3 times, most recently
from
00cc9b5 to
484fab4
Compare
JulienBalestra
force-pushed
the
JulienBalestra/ubuntu-1404
branch
from
484fab4 to
43bb13f
Compare
Collaborator
Author
|
There are some issues with the kubelet on Kubernetes 1.5 and 1.6. |
JulienBalestra
force-pushed
the
JulienBalestra/ubuntu-1404
branch
from
6291de2 to
287c740
Compare
JulienBalestra
force-pushed
the
JulienBalestra/ubuntu-1404
branch
from
287c740 to
9774507
Compare
CharlyF
reviewed
Jun 18, 2018
| --healthz-port=10248 \ | ||
| --cert-dir=/var/lib/p8s-kubelet/pki \ | ||
| --kubeconfig={{.RootABSPath}}/manifest-config/kubeconfig-insecure.yaml \ | ||
| --cloud-provider="" \ |
Contributor
There was a problem hiding this comment.
Are we planning on supporting this flag at some point ? (referring to @kindermoumoute's issue)
Collaborator
Author
There was a problem hiding this comment.
Yes we should, but it's not something needed for our use case right now.
CharlyF
reviewed
Jun 18, 2018
Contributor
CharlyF
left a comment
CharlyF
left a comment
There was a problem hiding this comment.
This looks good to me overall, just a general feedback - Exported methods need a comment, it'd greatly help to fully understand the scope of each method.
Collaborator
Author
|
@CharlyF I'll submit a PR to include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows to run pupernetes over old systemd platform like ubuntu 14.04.
As it's the only choice in several SaaS CI (circleci, travis) I managed to make it works over this distribution.
Motivation
Be able to run pupernetes in circleci.
This is very useful to be able to test pupernetes in its own CI system.
But, it's also very interesting for others projects like datadog-agent 🎉