Skip to content

chore(antithesis): LogLevel set only to 'error'#1937

Merged
blt merged 1 commit into
mainfrom
blt/chore_antithesis_loglevel_set_only_to_error_
Jun 30, 2026
Merged

chore(antithesis): LogLevel set only to 'error'#1937
blt merged 1 commit into
mainfrom
blt/chore_antithesis_loglevel_set_only_to_error_

Conversation

@blt

@blt blt commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

In the future I would like to allow variability in the loglevel but
today there's no clear -- to me -- way to set 'off' between the two SUT.
Error will do for now.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

References

@dd-octo-sts dd-octo-sts Bot added the area/test All things testing: unit/integration, correctness, SMP regression, etc. label Jun 26, 2026
@datadog-datadog-prod-us1

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Jun 26, 2026

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: cecbfe8 · Comparison: 7e405b9 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.48 MiB (baseline) vs 40.48 MiB (comparison)
Size Change: -16 B (-0.00%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.13073638391369616896 -130 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.624234684998051965 +128 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.13073638391369616896 -115 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.624234684998051965 +113 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.13073638391369616896 -109 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.624234684998051965 +107 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.13073638391369616896 -97 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.624234684998051965 +95 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.13073638391369616896 -95 B 1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.624234684998051965 +93 B 1
[Unmapped] -6 B 1
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +128  [NEW]     +40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.624234684998051965
  [NEW]    +113  [NEW]     +25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.624234684998051965
  [NEW]    +107  [NEW]     +19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.624234684998051965
  [NEW]     +95  [NEW]      +7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.624234684998051965
  [NEW]     +93  [NEW]      +5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.624234684998051965
  -0.1%      -6  [ = ]       0    [Unmapped]
  [DEL]     -95  [DEL]      -5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.13073638391369616896
  [DEL]     -97  [DEL]      -7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.13073638391369616896
  [DEL]    -109  [DEL]     -19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.13073638391369616896
  [DEL]    -115  [DEL]     -25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.13073638391369616896
  [DEL]    -130  [DEL]     -40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.13073638391369616896
  -0.0%     -16  [ = ]       0    TOTAL

@pr-commenter

pr-commenter Bot commented Jun 26, 2026

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: 7022b945-493c-4136-a30f-0d85c65d9f34
Baseline: cecbfe8a · Comparison: 7e405b9d · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_dsd_medium memory ⚪ +0.20 metrics profiles logs
quality_gates_rss_dsd_low memory ⚪ +0.07 metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory ⚪ +0.04 metrics profiles logs
quality_gates_rss_dsd_heavy memory ⚪ -0.10 metrics profiles logs
quality_gates_rss_idle memory ⚪ -0.22 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 131 MiB ≤ 140 MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 42.2 MiB ≤ 50 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 64.2 MiB ≤ 75 MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 191 MiB ≤ 200 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 27.8 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

In the future I would like to allow variability in the loglevel but
today there's no clear way to set 'off' between the two SUT. Error
will have to do for now.
@blt blt force-pushed the blt/chore_antithesis_loglevel_set_only_to_error_ branch from 91a4119 to 7e405b9 Compare June 30, 2026 01:55
@blt blt requested a review from Copilot June 30, 2026 14:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@blt blt marked this pull request as ready for review June 30, 2026 14:45
@blt blt requested review from a team as code owners June 30, 2026 14:45
@blt blt merged commit df6e5a1 into main Jun 30, 2026
85 checks passed

blt commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jun 30, 3:21 PM UTC: @blt merged this pull request with Graphite.

@blt blt deleted the blt/chore_antithesis_loglevel_set_only_to_error_ branch June 30, 2026 15:21
dd-octo-sts Bot pushed a commit that referenced this pull request Jun 30, 2026
## Summary
<!-- Please provide a brief summary about what this PR does.
This should help the reviewers give feedback faster and with higher quality. -->

In the future I would like to allow variability in the loglevel but
today there's no clear -- to me -- way to set 'off' between the two SUT.
Error will do for now.

## Change Type
- [ ] Bug fix
- [ ] New feature
- [x] Non-functional (chore, refactoring, docs)
- [ ] Performance

## How did you test this PR?
<!-- Please how you tested these changes here -->

## References

<!-- Please list any issues closed by this PR. -->

<!--
- Closes: <issue link>
-->

<!-- Any other issues or PRs relevant to this PR? Feel free to list them here. --> df6e5a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test All things testing: unit/integration, correctness, SMP regression, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants