chore(antithesis): Generate configs for scenario purposes by blt · Pull Request #1938 · DataDog/saluki

blt · 2026-06-26T21:12:12Z

Summary

ADP and Datadog Agent support an intersection of datadog.yaml config
options but ADP has distinct configuration from Datadog Agent and vice
versa. Some of that is temporary, some is a permanent state. This PR
adapts the config generator to produce intersection datadog.yaml instances.

Change Type

Bug fix
New feature
Non-functional (chore, refactoring, docs)
Performance

How did you test this PR?

References

blt · 2026-06-26T21:12:25Z

pr-commenter · 2026-06-26T21:20:07Z

Binary Size Analysis (Agent Data Plane)

Baseline: 4b4f85a · Comparison: 9ceef13 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.85 MiB (baseline) vs 40.85 MiB (comparison)
Size Change: +0 B (+0.00%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.4282624094521442511`	+129 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.5374507731692200910`	-129 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.4282624094521442511`	+114 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.5374507731692200910`	-114 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.4282624094521442511`	+108 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.5374507731692200910`	-108 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.4282624094521442511`	+96 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.5374507731692200910`	-96 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.4282624094521442511`	+94 B	1
`anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.5374507731692200910`	-94 B	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.4282624094521442511
  [NEW]    +114  [NEW]     +25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.4282624094521442511
  [NEW]    +108  [NEW]     +19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.4282624094521442511
  [NEW]     +96  [NEW]      +7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.4282624094521442511
  [NEW]     +94  [NEW]      +5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.4282624094521442511
  [DEL]     -94  [DEL]      -5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.5374507731692200910
  [DEL]     -96  [DEL]      -7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.5374507731692200910
  [DEL]    -108  [DEL]     -19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.5374507731692200910
  [DEL]    -114  [DEL]     -25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.5374507731692200910
  [DEL]    -129  [DEL]     -40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.5374507731692200910
  [ = ]       0  [ = ]       0    TOTAL

pr-commenter · 2026-06-26T21:34:14Z

Regression Detector (Agent Data Plane)

Run ID: bdb5c27a-ba5e-4e71-8393-d314e13d1093
Baseline: 4b4f85ac · Comparison: 9ceef13b · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
quality_gates_rss_dsd_heavy	memory	⚪ +0.20	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ +0.06	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ -0.01	metrics profiles logs
quality_gates_rss_idle	memory	⚪ -0.09	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ -0.29	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 131 MiB ≤ 140 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 42.8 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 65.5 MiB ≤ 75 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 191 MiB ≤ 200 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 28.7 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0e4ead938

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ADP and Datadog Agent support an intersection of datadog.yaml config options but ADP has distinct configuration from Datadog Agent and vice versa. Some of that is temporary, some is a permanent state.

blt · 2026-07-02T16:55:13Z

Merge activity

Jul 2, 4:55 PM UTC: @blt merged this pull request with Graphite.

## Summary  ADP and Datadog Agent support an intersection of datadog.yaml config options but ADP has distinct configuration from Datadog Agent and vice versa. Some of that is temporary, some is a permanent state. This PR adapts the config generator to produce intersection datadog.yaml instances. ## Change Type - [ ] Bug fix - [ ] New feature - [x] Non-functional (chore, refactoring, docs) - [ ] Performance ## How did you test this PR?  ## References    1d0f918

dd-octo-sts Bot added the area/test All things testing: unit/integration, correctness, SMP regression, etc. label Jun 26, 2026

blt mentioned this pull request Jun 26, 2026

chore(antithesis): Differential comparison between ADP and Datadog Agent context egress #1891

Open

4 tasks

blt mentioned this pull request Jun 26, 2026

chore(antithesis): LogLevel set only to 'error' #1937

Merged

4 tasks

This was referenced Jun 30, 2026

chore(antithesis): Track dropped transactions in as sometimes! assertion #1949

Open

chore(antithesis): Parallel drivers retry sends #1950

Merged

This comment has been minimized.

Sign in to view

blt force-pushed the blt/chore_antithesis_loglevel_set_only_to_error_ branch from 91a4119 to 7e405b9 Compare June 30, 2026 01:55

blt force-pushed the blt/chore_antithesis_generate_configs_for_scenario_purposes branch from e839e5a to 67ec949 Compare June 30, 2026 01:56

blt commented Jun 30, 2026

View reviewed changes

Comment thread test/antithesis/scenarios/differential/docker-compose.yaml Outdated

blt force-pushed the blt/chore_antithesis_generate_configs_for_scenario_purposes branch from 67ec949 to da4c048 Compare June 30, 2026 14:35

blt marked this pull request as ready for review June 30, 2026 14:46

blt requested a review from a team as a code owner June 30, 2026 14:46

Copilot AI review requested due to automatic review settings June 30, 2026 14:46

blt requested a review from a team as a code owner June 30, 2026 14:46

Copilot AI reviewed Jun 30, 2026

blt changed the base branch from blt/chore_antithesis_loglevel_set_only_to_error_ to graphite-base/1938 June 30, 2026 15:20

blt force-pushed the graphite-base/1938 branch from 7e405b9 to df6e5a1 Compare June 30, 2026 15:21

blt force-pushed the blt/chore_antithesis_generate_configs_for_scenario_purposes branch from da4c048 to c4bd83e Compare June 30, 2026 15:21

graphite-app Bot changed the base branch from graphite-base/1938 to main June 30, 2026 15:21

blt force-pushed the blt/chore_antithesis_generate_configs_for_scenario_purposes branch 2 times, most recently from 51d3177 to c0e4ead Compare July 1, 2026 15:56

This was referenced Jul 1, 2026

chore(antithesis): Add two new Pyld properties #1960

Open

chore(antithesis): Add Pyld25, series are not empty #1961

Open

chatgpt-codex-connector Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread test/antithesis/harness/src/config.rs Outdated

Comment thread test/antithesis/harness/src/config.rs Outdated

blt mentioned this pull request Jul 2, 2026

chore(antithesis): dogstatsd generation with byte limit #1974

Open

4 tasks

chore(antithesis): Generate configs for scenario purposes

9ceef13

ADP and Datadog Agent support an intersection of datadog.yaml config options but ADP has distinct configuration from Datadog Agent and vice versa. Some of that is temporary, some is a permanent state.

blt force-pushed the blt/chore_antithesis_generate_configs_for_scenario_purposes branch from c0e4ead to 9ceef13 Compare July 2, 2026 13:44

tobz approved these changes Jul 2, 2026

View reviewed changes

blt merged commit 1d0f918 into main Jul 2, 2026
85 checks passed

blt deleted the blt/chore_antithesis_generate_configs_for_scenario_purposes branch July 2, 2026 16:55

blt mentioned this pull request Jul 6, 2026

chore(antithesis): Pin all rig container dependencies #2017

Draft

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(antithesis): Generate configs for scenario purposes#1938

chore(antithesis): Generate configs for scenario purposes#1938
blt merged 1 commit into
mainfrom
blt/chore_antithesis_generate_configs_for_scenario_purposes

blt commented Jun 26, 2026 •

edited

Loading

Uh oh!

blt commented Jun 26, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blt commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

blt commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type

How did you test this PR?

References

Uh oh!

blt commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Analysis (Agent Data Plane)

✅ Binary size difference within threshold

Uh oh!

pr-commenter Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector (Agent Data Plane)

Optimization Goals: ✅ No significant changes detected

Uh oh!

This comment has been minimized.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blt commented Jul 2, 2026

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

blt commented Jun 26, 2026 •

edited

Loading

blt commented Jun 26, 2026 •

edited

Loading

pr-commenter Bot commented Jun 26, 2026 •

edited

Loading

pr-commenter Bot commented Jun 26, 2026 •

edited

Loading